8000 gh-132261: Store annotations at hidden internal keys in the class dict by JelleZijlstra · Pull Request #132345 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132261: Store annotations at hidden internal keys in the class dict #132345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2025
Merged

gh-132261: Store annotations at hidden internal keys in the class dict #132345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40ce340
annotate_func
JelleZijlstra Apr 8, 2025
fcbedff
Also change annotations
JelleZijlstra Apr 10, 2025
dbe559f
actually bump the magic
JelleZijlstra Apr 10, 2025
4ebfcfb
fix tests
JelleZijlstra Apr 10, 2025
cb4bff2
Update Misc/NEWS.d/next/Core_and_Builtins/2025-04-09-21-51-37.gh-issu…
JelleZijlstra Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Apr 10, 2025
commit 4ebfcfbcd3732d0da4f4e9855588bc0fe0bddf90
3 changes: 2 additions & 1 deletion Lib/pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,8 @@ def visiblename(name, all=None, obj=None):
'__date__', '__doc__', '__file__', '__spec__',
'__loader__', '__module__', '__name__', '__package__',
'__path__', '__qualname__', '__slots__', '__version__',
'__static_attributes__', '__firstlineno__'}:
'__static_attributes__', '__firstlineno__',
'__annotate_func__', '__annotations_cache__'}:
return 0
# Private names are hidden, but special names are displayed.
if name.startswith('__') and name.endswith('__'): return 1
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_ast/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def test_arguments(self):
x = ast.arguments()
self.assertEqual(x._fields, ('posonlyargs', 'args', 'vararg', 'kwonlyargs',
'kw_defaults', 'kwarg', 'defaults'))
self.assertEqual(x.__annotations__, {
self.assertEqual(ast.arguments.__annotations__, {
'posonlyargs': list[ast.arg],
'args': list[ast.arg],
'vararg': ast.arg | None,
Expand Down
8 changes: 0 additions & 8 deletions Lib/test/test_pydoc/test_pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@ class A(builtins.object)
| __weakref__%s

class B(builtins.object)
| Methods defined here:
|
| __annotate__(format, /)
|
| ----------------------------------------------------------------------
| Data descriptors defined here:
|
| __dict__%s
Expand Down Expand Up @@ -180,9 +175,6 @@ class A(builtins.object)
list of weak references to the object

class B(builtins.object)
Methods defined here:
__annotate__(format, /)
----------------------------------------------------------------------
Data descriptors defined here:
__dict__
dictionary for instance variables
Expand Down
Loading
0