8000 gh-132185: Speed up expanduser() test with large password database by serhiy-storchaka · Pull Request #132231 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132185: Speed up expanduser() test with large password database #132231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 12, 2025
Merged

gh-132185: Speed up expanduser() test with large password database #132231

merged 6 commits into from
Apr 12, 2025

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Apr 7, 2025 •
edited by bedevere-app bot
Loading

Use only random selected entries if the "cpu" resource is not enabled.

@serhiy-storchaka
pythongh-132185: Speed up expanduser() test with large password database
6123d16 
Use only random selected entries if the "cpu" resource is not enabled.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Apr 7, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 7, 2025
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 7, 2025
Closed
@serhiy-storchaka
Copy link
Member Author

@itamaro, how much it takes to test 1000 entries? 10000 entries?

@itamaro
Copy link
Contributor
itamaro commented Apr 7, 2025

@itamaro, how much it takes to test 1000 entries? 10000 entries?

let me test with these limits

@itamaro
Copy link
Contributor
itamaro commented Apr 7, 2025

@itamaro, how much it takes to test 1000 entries? 10000 entries?

about a minute for 10k, under 5sec for 1k

@serhiy-storchaka
Copy link
Member Author

Thank you. This is much slower than on normal Linux PC, so I would be wrong without your data.

itamaro
itamaro reviewed Apr 7, 2025
View reviewed changes
picnixz
picnixz reviewed Apr 7, 2025
View reviewed changes
@serhiy-storchaka @picnixz
Update Lib/test/test_posixpath.py
a4f6f60 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 9, 2025
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) April 12, 2025 15:50
@serhiy-storchaka serhiy-storchaka merged commit 842ab81 into python:main Apr 12, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2025
@serhiy-storchaka @miss-islington
pythongh-132185: Speed up expanduser() test with large password datab…
5f3c710 
…ase (pythonGH-132231)

Use only a limited number of randomly selected entries.
(cherry picked from commit 842ab81)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Apr 12, 2025

GH-132443 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 12, 2025
serhiy-storchaka added a commit that referenced this pull request Apr 12, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-132185: Speed up expanduser() test with large password data…
f943376 
…base (GH-132231) (GH-132443)

Use only a limited number of randomly selected entries.
(cherry picked from commit 842ab81)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamaro itamaro itamaro approved these changes

@picnixz picnixz picnixz approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @itamaro @picnixz @hugovk
0