gh-132171: Fix _interpreters.run_string crash on string subclass
#132173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
approved these changes
Apr 7, 2025
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
8000
Apr 7, 2025
…ass (pythonGH-132173) (cherry picked from commit 3980718) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-132219 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
that referenced
this pull request
Apr 7, 2025
| @@ -330,7 +330,7 @@ get_code_str(PyObject *arg, Py_ssize_t *len_p, PyObject **bytes_p, int *flags_p) | |||
| int flags = 0; | |||
|
|
|||
| if (PyUnicode_Check(arg)) { | |||
| assert(PyUnicode_CheckExact(arg) | |||
| assert(PyUnicode_Check(arg) | |||
There was a problem hiding this comment.
check is already happening in the if condition, then why do the check again? Shouldn't we remove it?
There was a problem hiding this comment.
In hindsight, sure. But I don't think it's worth changing it now; it's not wrong, it's just redundant.
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_interpreters.run_stringwith a string subclass instance #132171