10000 gh-132132: Upgrade LLVM on tail calling CI by Fidget-Spinner · Pull Request #132098 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content
10000

gh-132132: Upgrade LLVM on tail calling CI #132098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 5, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update remote_debugging.c
  • Loading branch information
Fidget-Spinner committed Apr 4, 2025
commit 04d34df053c5ebe19b887364d31c124de17756b9
2 changes: 1 addition & 1 deletion Python/remote_debugging.c
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ get_py_runtime(proc_handle_t* handle)
#else
const char* secname = "PyRuntime";
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use secname instead of "PyRuntime" below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah oops 🤦 thanks 3AM things.

address = search_windows_map_for_section(handle, "PyRuntime", L"python");
address = search_windows_map_for_section(handle, secname, L"python");
if (address == 0) {
// Error out: 'python' substring covers both executable and DLL
PyErr_SetString(PyExc_RuntimeError, "Failed to find the PyRuntime section in the process.");
Expand Down
Loading
0