10000 gh-132075: Fix possible use of sockaddr structures with uninitialized members by serhiy-storchaka · Pull Request #132076 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132075: Fix possible use of sockaddr structures with uninitialized members #132076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

gh-132075: Fix possible use of sockaddr structures with uninitialized members #132076

merged 1 commit into from
Apr 4, 2025

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Apr 4, 2025 •
edited by bedevere-app bot
Loading

Now all structure members are initialized with zeroes by default.

@serhiy-storchaka
pythongh-132075: Fix possible use of sockaddr structures with uniniti…
f882d1e 
…alized members

Now all structure members are initialized with zeroes by default.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Apr 4, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 4, 2025
Closed
@serhiy-storchaka
Copy link
Member Author

!buildbot AMD64 Fedora Stable

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit f882d1e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132076%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 Fedora Stable

The builders matched are:

  • AMD64 Fedora Stable LTO + PGO PR
  • AMD64 Fedora Stable Refleaks PR
  • AMD64 Fedora Stable Clang PR
  • AMD64 Fedora Stable Clang Installed PR
  • AMD64 Fedora Stable LTO PR
  • AMD64 Fedora Stable PR

@serhiy-storchaka
Copy link
Member Author

!buildbot ARM Raspbian

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit f882d1e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132076%2Fmerge

The command will test the builders whose names match following regular expression: ARM Raspbian

The builders matched are:

  • ARM Raspbian PR

@serhiy-storchaka serhiy-storchaka merged commit 345baa7 into python:main Apr 4, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2025
@serhiy-storchaka @miss-islington
pythongh-132075: Fix possible use of sockaddr structures with uniniti…
8fc3d49 
…alized members (pythonGH-132076)

Now all structure members are initialized with zeroes by default.
(cherry picked from commit 345baa7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2025
@serhiy-storchaka @miss-islington
pythongh-132075: Fix possible use of sockaddr structures with uniniti…
913523a 
…alized members (pythonGH-132076)

Now all structure members are initialized with zeroes by default.
(cherry picked from commit 345baa7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Apr 4, 2025

GH-132086 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 4, 2025
@bedevere-app
Copy link
bedevere-app bot commented Apr 4, 2025

GH-132087 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 4, 2025
serhiy-storchaka added a commit that referenced this pull request Apr 4, 2025
@miss-islington @serhiy-storchaka
[3.12] gh-132075: Fix possible use of sockaddr structures with uninit…
10f73f7 
…ialized members (GH-132076) (GH-132087)

Now all structure members are initialized with zeroes by default.
(cherry picked from commit 345baa7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Apr 4, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-132075: Fix possible use of sockaddr structures with uninit…
0c0ffbe 
…ialized members (GH-132076) (GH-132086)

Now all structure members are initialized with zeroes by default.
(cherry picked from commit 345baa7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
9E71 Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.13 (tier-3) has failed when building commit 0c0ffbe.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1386/builds/1154) and take a look at the build logs.
  4. Check if the failure is related to this commit (0c0ffbe) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1386/builds/1154

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/68D50FDB-0C1F-43FA-9605-1738953A53E8/data/Containers/Bundle/Application/EC030906-C661-446A-8159-D1D9362FAC14/iOSTestbed.app/python/lib/python3.13/threading.py", line 1041, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/68D50FDB-0C1F-43FA-9605-1738953A53E8/data/Containers/Bundle/Application/EC030906-C661-446A-8159-D1D9362FAC14/iOSTestbed.app/python/lib/python3.13/threading.py", line 992, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/68D50FDB-0C1F-43FA-9605-1738953A53E8/data/Containers/Bundle/Application/EC030906-C661-446A-8159-D1D9362FAC14/iOSTestbed.app/python/lib/python3.13/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/Users/buildbot/Library/Developer/XCTestDevices/68D50FDB-0C1F-43FA-9605-1738953A53E8/data/Containers/Bundle/Application/EC030906-C661-446A-8159-D1D9362FAC14/iOSTestbed.app/python/lib/python3.13/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@serhiy-storchaka @seehwan80
pythongh-132075: Fix possible use of sockaddr structures with uniniti…
e53530c 
…alized members (pythonGH-132076)

Now all structure members are initialized with zeroes by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @bedevere-bot
0