8000 gh-132011: Fix crash on invalid `CALL_LIST_APPEND` deoptimization by sobolevn · Pull Request #132018 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132011: Fix crash on invalid CALL_LIST_APPEND deoptimization #132018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 6, 2025
Merged

gh-132011: Fix crash on invalid CALL_LIST_APPEND deoptimization #132018

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3f4db45
gh-132011: Fix crash on invalid `CALL_LIST_APPEND` deoptimization
sobolevn Apr 2, 2025
cac64f1
Update Lib/test/test_list.py
sobolevn Apr 2, 2025
210772f
Apply suggestions from code review
sobolevn Apr 2, 2025
f868359
Address review
sobolevn Apr 2, 2025
0b94d0c
Update Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issu…
sobolevn Apr 2, 2025
1723717
Merge branch 'main' into issue-132011
sobolevn Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
  • Loading branch information
@sobolevn @ZeroIntensity
sobolevn and ZeroIntensity authored Apr 2, 2025
commit 210772f387b581e1dd6547a35e8f75be6789f2bf
2 changes: 1 addition & 1 deletion Lib/test/test_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def test_no_memory(self):

def test_deopt_from_append_list(self):
# gh-132011: it used to crash, because
# of `CALL_LIST_APPEND` specializetion failure.
# of `CALL_LIST_APPEND` specialization failure.
code = textwrap.dedent("""
l = []
def lappend(l, x, y):
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issue-132011.dNh64H.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Fix crash on incorrect ``CALL_LIST_APPEND`` deoptimization.
Fix crash when calling :meth:`list.append` as an unbound method.
Loading
0