8000 gh-132013: use relaxed atomics in hash of frozenset by kumaraditya303 · Pull Request #132014 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132013: use relaxed atomics in hash of frozenset #132014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

gh-132013: use relaxed atomics in hash of frozenset #132014

merged 1 commit into from
Apr 2, 2025

Conversation

kumaraditya303
Copy link
Contributor
@kumaraditya303 kumaraditya303 commented Apr 2, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 2, 2025
Closed
corona10
corona10 approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member
@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kumaraditya303 kumaraditya303 merged commit 76f6b5e into python:main Apr 2, 2025
51 checks passed
@kumaraditya303 kumaraditya303 deleted the frozen branch April 2, 2025 14:31
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x (tier-2) has failed when building commit 76f6b5e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/725/builds/10326) and take a look at the build logs.
  4. Check if the failure is related to this commit (76f6b5e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/725/builds/10326

Failed tests:

  • test_idle

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/idlelib/idle_test/test_squeezer.py", line 191, in test_write_stdout
    self.assertEqual(squeezer.editwin.write(text, "stdout"), None)
                     ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/idlelib/squeezer.py", line 262, in mywrite
    expandingbutton = ExpandingButton(s, tags, numoflines, self)
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/idlelib/squeezer.py", line 116, in __init__
    if macosx.isAquaTk():
       ~~~~~~~~~~~~~~~^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/idlelib/macosx.py", line 56, in isAquaTk
    _init_tk_type()
    ~~~~~~~~~~~~~^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/idlelib/macosx.py", line 36, in _init_tk_type
    root = tkinter.Tk()
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/tkinter/__init__.py", line 2461, in __init__
    self.tk = _tkinter.create(screenName, baseName, className, interactive, wantobjects, useTk, sync, use)
              ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_tkinter.TclError: Can't find a usable tk.tcl in the following directories: 
    //zipfs:/app/tk_library //zipfs:/lib/tk/tk_library //zipfs:/lib/tk /opt/homebrew/Cellar/tcl-tk/9.0.1/lib/tk9.0 /opt/homebrew/Cellar/tcl-tk/9.0.1/lib/tcl9.0/tk9.0 /opt/homebrew/Cellar/tcl-tk/9.0.1/lib/tcl9.0/tk9.0/Resources/Scripts /opt/homebrew/Cellar/tcl-tk/9.0.1/lib/tk9.0 /opt/homebrew/Cellar/tcl-tk/9.0.1/lib/tk9.0/Resources/Scripts /Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/lib/tk9.0 /Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/lib/tk9.0/Resources/Scripts /opt/homebrew/lib/tk9.0 /opt/homebrew/lib/tk9.0/Resources/Scripts /Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/lib/tk9.0 /Users/buildbot/buildarea/lib/tk9.0 /Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/library

@kumaraditya303 kumaraditya303 added the needs backport to 3.13 bugs and security fixes label Apr 8, 2025
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link
miss-islington-app bot 8000 commented Apr 8, 2025

Sorry, @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 76f6b5e64a8b6ea5a88606f3665cd9f52c2c2798 3.13

kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Apr 12, 2025
@kumaraditya303
pythongh-132013: use relaxed atomics in hash of frozenset (python#132014
c897d92 
)

Use relaxed atomics in hash of `frozenset` to fix TSAN warning.
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@kumaraditya303 @seehwan80
pythongh-132013: use relaxed atomics in hash of frozenset (python#132014
7c27ed2 
)

Use relaxed atomics in hash of `frozenset` to fix TSAN warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels
needs backport to 3.13 bugs and security fixes skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @bedevere-bot @corona10
0