8000 [3.5] bpo-36816: Update the self-signed.pythontest.net cert (GH-13192) by gpshead · Pull Request #13200 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
8000

[3.5] bpo-36816: Update the self-signed.pythontest.net cert (GH-13192) #13200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2019
Merged

[3.5] bpo-36816: Update the self-signed.pythontest.net cert (GH-13192) #13200

merged 3 commits into from
Jul 13, 2019

Conversation

gpshead
Copy link
Member
@gpshead gpshead commented May 8, 2019 •
edited
Loading

We updated the server, our testsuite must match.

https://bugs.python.org/issue36816

✈️ CLE -> DEN -> SFO ✈️ #pycon2019 #smoothjazz
(cherry picked from commit 6bd8173)

Authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue36816

@gpshead
[3.5] bpo-36816: Update the self-signed.pythontest.net cert (pythonGH…
18d98b1 
…-13192)

We updated the server, our testsuite must match.

https://bugs.python.org/issue36816

✈️ CLE -> DEN ✈️ GH-pycon2019
(cherry picked from commit 6bd8173)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot added sprint tests Tests in the Lib/test dir labels May 8, 2019
@gpshead
Add the capath copy.
f6dab3a 
The 3.5 tree also needed a certificate in the capath directory updated.
The filename for that was determined by `openssl x509 -in $cert.pem -subject_hash`.
@gpshead
Copy link
Member Author
gpshead commented May 9, 2019

without this PR, python3.5 -m test.regrtest -u all test_httplib test_ssl will fail due to a certificate mismatch vs the updated cert on our server.

@vstinner vstinner mentioned this pull request May 21, 2019
Merged
vstinner
vstinner approved these changes May 21, 2019
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This PR is needed for PR #13207, an important security fix: prevent HTTP Header Injection.

@larryhastings larryhastings merged commit 221178a into python:3.5 Jul 13, 2019
@bedevere-bot
Copy link

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Contributor

Thanks for the 3.5 love!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@larryhastings larryhastings

Labels
sprint tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gpshead @bedevere-bot @larryhastings @vstinner @the-knights-who-say-ni
0