8000 GH-131798: Remove guard for known type in TO_BOOL_STR by fluhus · Pull Request #131816 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-131798: Remove guard for known type in TO_BOOL_STR #131816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 30, 2025
Merged

GH-131798: Remove guard for known type in TO_BOOL_STR #131816

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ddcb309
Break down TO_BOOL_STR into guard and to-bool
fluhus Mar 26, 2025
be138d0
Merge branch 'python:main' into amit
fluhus Mar 26, 2025
e1f788a
Fix optimizer TO_BOOL_STR
fluhus Mar 26, 2025
64aa8eb
Add test for optimizer TOS string guard removal
fluhus Mar 26, 2025
5f06e7f
Merge branch 'python:main' into amit
fluhus Mar 28, 2025
7487669
Style fixes in TO_BOOL_STR
fluhus Mar 28, 2025
6db1a79
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 28, 2025
138f037
Remove unneeded type assignment in _GUARD_TOS_UNICODE
fluhus Mar 29, 2025
42ca29c
Move type assignment from _TO_BOOL_STR to _GUARD_TOS_UNICODE
fluhus Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for optimizer TOS string guard removal
  • Loading branch information
@fluhus
fluhus committed Mar 26, 2025
commit 64aa8ebc4d3c357c593b70d87fa76aa307ca2b56
18 changes: 18 additions & 0 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,6 +1581,24 @@ def testfunc(n):
self.assertNotIn("_COMPARE_OP_INT", uops)
self.assertIn("_POP_TWO_LOAD_CONST_INLINE_BORROW", uops)

def test_remove_guard_for_known_type_str(self):
def f(n):
for i in range(n):
false = i == TIER2_THRESHOLD
empty = "X"[:false]
empty += "" # Make JIT realize this is a string.
if empty:
return 1
return 0

res, ex = self._run_with_optimizer(f, TIER2_THRESHOLD)
self.assertEqual(res, 0)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_TO_BOOL_STR", uops)
self.assertNotIn("_GUARD_TOS_UNICODE", uops)


def global_identity(x):
return x

Expand Down
0