8000 gh-132097: allow AC to disable fastcall convention to avoid UBSan failures by picnixz · Pull Request #131605 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-132097: allow AC to disable fastcall convention to avoid UBSan failures #131605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 18, 2025
Merged

gh-132097: allow AC to disable fastcall convention to avoid UBSan failures #131605

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ea6e46b
remove unused casts by clinic
picnixz Mar 20, 2025
4001c73
fixup
picnixz Mar 20, 2025
1480166
Revert "fixup"
picnixz Mar 20, 2025
a737ca5
fixup
picnixz Mar 20, 2025
6f20fc9
fixup
picnixz Mar 20, 2025
45f38a7
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Mar 23, 2025
1331a3e
move comments
picnixz Mar 23, 2025
df2d466
move comments
picnixz Mar 23, 2025
dfe5c9d
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Mar 24, 2025
d032ba0
revert cast removal
picnixz Mar 24, 2025
abd0f7c
make clinic
picnixz Mar 24, 2025
54a80c8
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Apr 3, 2025
18022f3
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te…
picnixz Apr 4, 2025
0b437c4
GH-131498: Cases generator: manage stacks automatically (GH-132074)
markshannon Apr 4, 2025
e115ce3
gh-99108: Implement HACL* HMAC (#130157)
picnixz Apr 4, 2025
5695216
Merge branch 'main' into fix/ubsan/clinic-test-111178
picnixz Apr 5, 2025
107983d
Merge remote-tracking branch 'upstream/main' into fix/ubsan/clinic-te… 8000
picnixz Apr 5, 2025
65c64bc
check arguments given to the 'disable' directive
picnixz Apr 5, 2025
eec145e
Merge branch 'main' into fix/ubsan/clinic-test-111178
picnixz Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make clinic
  • Loading branch information
@picnixz
picnixz committed Mar 24, 2025
8000
commit abd0f7c10a92a0f35189c1a4c1fc49b20a303c8a
76 changes: 38 additions & 38 deletions Lib/test/clinic.test.c
View file
Open in desktop
< A36C tr data-hunk="9389d935ca309cc43f9c11e4de82fb750241cd4a3a9f0ee3b2c71e59899a77ac" class="show-top-border">
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,11 @@ PyDoc_STRVAR(test_object_converter_one_arg__doc__,
"\n");

#define TEST_OBJECT_CONVERTER_ONE_ARG_METHODDEF \
{"test_object_converter_one_arg", test_object_converter_one_arg, METH_O, test_object_converter_one_arg__doc__},
{"test_object_converter_one_arg", (PyCFunction)test_object_converter_one_arg, METH_O, test_object_converter_one_arg__doc__},

static PyObject *
test_object_converter_one_arg(PyObject *module, PyObject *a)
/*[clinic end generated code: output=a1272d4a621e3280 input=d635d92a421f1ca3]*/
/*[clinic end generated code: output=6da755f8502139df input=d635d92a421f1ca3]*/


/*[clinic input]
Expand Down Expand Up @@ -315,7 +315,7 @@ PyDoc_STRVAR(test_PyBytesObject_converter__doc__,
"\n");

#define TEST_PYBYTESOBJECT_CONVERTER_METHODDEF \
{"test_PyBytesObject_converter", test_PyBytesObject_converter, METH_O, test_PyBytesObject_converter__doc__},
{"test_PyBytesObject_converter", (PyCFunction)test_PyBytesObject_converter, METH_O, test_PyBytesObject_converter__doc__},

static PyObject *
test_PyBytesObject_converter_impl(PyObject *module, PyBytesObject *a);
Expand All @@ -339,7 +339,7 @@ test_PyBytesObject_converter(PyObject *module, PyObject *arg)

static PyObject *
test_PyBytesObject_converter_impl(PyObject *module, PyBytesObject *a)
/*[clinic end generated code: output=a1f2b92832ee6372 input=12b10c7cb5750400]*/
/*[clinic end generated code: output=7539d628e6fceace input=12b10c7cb5750400]*/


/*[clinic input]
Expand All @@ -356,7 +356,7 @@ PyDoc_STRVAR(test_PyByteArrayObject_converter__doc__,
"\n");

#define TEST_PYBYTEARRAYOBJECT_CONVERTER_METHODDEF \
{"test_PyByteArrayObject_converter", test_PyByteArrayObject_converter, METH_O, test_PyByteArrayObject_converter__doc__},
{"test_PyByteArrayObject_converter", (PyCFunction)test_PyByteArrayObject_converter, METH_O, test_PyByteArrayObject_converter__doc__},

static PyObject *
test_PyByteArrayObject_converter_impl(PyObject *module, PyByteArrayObject *a);
Expand All @@ -380,7 +380,7 @@ test_PyByteArrayObject_converter(PyObject *module, PyObject *arg)

static PyObject *
test_PyByteArrayObject_converter_impl(PyObject *module, PyByteArrayObject *a)
/*[clinic end generated code: output=745c66001160f9cf input=5a657da535d194ae]*/
/*[clinic end generated code: output=1245af9f5b3e355e input=5a657da535d194ae]*/


/*[clinic input]
Expand All @@ -397,7 +397,7 @@ PyDoc_STRVAR(test_unicode_converter__doc__,
"\n");

#define TEST_UNICODE_CONVERTER_METHODDEF \
{"test_unicode_converter", test_unicode_converter, METH_O, test_unicode_converter__doc__},
{"test_unicode_converter", (PyCFunction)test_unicode_converter, METH_O, test_unicode_converter__doc__},

static PyObject *
test_unicode_converter_impl(PyObject *module, PyObject *a);
Expand All @@ -421,7 +421,7 @@ test_unicode_converter(PyObject *module, PyObject *arg)

static PyObject *
test_unicode_converter_impl(PyObject *module, PyObject *a)
/*[clinic end generated code: output=d3eba4040b357127 input=aa33612df92aa9c5]*/
/*[clinic end generated code: output=8c1625cc272c1f3d input=aa33612df92aa9c5]*/


/*[clinic input]
Expand Down Expand Up @@ -1857,7 +1857,7 @@ PyDoc_STRVAR(test_Py_complex_converter__doc__,
"\n");

#define TEST_PY_COMPLEX_CONVERTER_METHODDEF \
{"test_Py_complex_converter", test_Py_complex_converter, METH_O, test_Py_complex_converter__doc__},
{"test_Py_complex_converter", (PyCFunction)test_Py_complex_converter, METH_O, test_Py_complex_converter__doc__},

static PyObject *
test_Py_complex_converter_impl(PyObject *module, Py_complex a);
Expand All @@ -1880,7 +1880,7 @@ test_Py_complex_converter(PyObject *module, PyObject *arg)

static PyObject *
test_Py_complex_converter_impl(PyObject *module, Py_complex a)
/*[clinic end generated code: output=86f47ff04e11183c input=070f216a515beb79]*/
/*[clinic end generated code: output=c2ecbec2144ca540 input=070f216a515beb79]*/


/*[clinic input]
Expand Down Expand Up @@ -4001,7 +4001,7 @@ PyDoc_STRVAR(test_preprocessor_guarded_condition_a__doc__,
"\n");

#define TEST_PREPROCESSOR_GUARDED_CONDITION_A_METHODDEF \
{"test_preprocessor_guarded_condition_a", test_preprocessor_guarded_condition_a, METH_NOARGS, test_preprocessor_guarded_condition_a__doc__},
{"test_preprocessor_guarded_condition_a", (PyCFunction)test_preprocessor_guarded_condition_a, METH_NOARGS, test_preprocessor_guarded_condition_a__doc__},

static PyObject *
test_preprocessor_guarded_condition_a(PyObject *module, PyObject *Py_UNUSED(ignored))
Expand All @@ -4019,7 +4019,7 @@ PyDoc_STRVAR(test_preprocessor_guarded_elif_condition_b__doc__,
"\n");

#define TEST_PREPROCESSOR_GUARDED_ELIF_CONDITION_B_METHODDEF \
{"test_preprocessor_guarded_elif_condition_b", test_preprocessor_guarded_elif_condition_b, METH_NOARGS, test_preprocessor_guarded_elif_condition_b__doc__},
{"test_preprocessor_guarded_elif_condition_b", (PyCFunction)test_preprocessor_guarded_elif_condition_b, METH_NOARGS, test_preprocessor_guarded_elif_condition_b__doc__},

static PyObject *
test_preprocessor_guarded_elif_condition_b(PyObject *module, PyObject *Py_UNUSED(ignored))
Expand All @@ -4037,7 +4037,7 @@ PyDoc_STRVAR(test_preprocessor_guarded_else__doc__,
"\n");

#define TEST_PREPROCESSOR_GUARDED_ELSE_METHODDEF \
{"test_preprocessor_guarded_else", test_preprocessor_guarded_else, METH_NOARGS, test_preprocessor_guarded_else__doc__},
{"test_preprocessor_guarded_else", (PyCFunction)test_preprocessor_guarded_else, METH_NOARGS, test_preprocessor_guarded_else__doc__},

static PyObject *
test_preprocessor_guarded_else(PyObject *module, PyObject *Py_UNUSED(ignored))
Expand All @@ -4055,7 +4055,7 @@ PyDoc_STRVAR(test_preprocessor_guarded_ifndef_condition_c__doc__,
"\n");

#define TEST_PREPROCESSOR_GUARDED_IFNDEF_CONDITION_C_METHODDEF \
{"test_preprocessor_guarded_ifndef_condition_c", test_preprocessor_guarded_ifndef_condition_c, METH_NOARGS, test_preprocessor_guarded_ifndef_condition_c__doc__},
{"test_preprocessor_guarded_ifndef_condition_c", (PyCFunction)test_preprocessor_guarded_ifndef_condition_c, METH_NOARGS, test_preprocessor_guarded_ifndef_condition_c__doc__},

static PyObject *
test_preprocessor_guarded_ifndef_condition_c(PyObject *module, PyObject *Py_UNUSED(ignored))
Expand All @@ -4073,7 +4073,7 @@ PyDoc_STRVAR(test_preprocessor_guarded_ifndef_not_condition_c__doc__,
"\n");

#define TEST_PREPROCESSOR_GUARDED_IFNDEF_NOT_CONDITION_C_METHODDEF \
{"test_preprocessor_guarded_ifndef_not_condition_c", test_preprocessor_guarded_ifndef_not_condition_c, METH_NOARGS, test_preprocessor_guarded_ifndef_not_condition_c__doc__},
{"test_preprocessor_guarded_ifndef_not_condition_c", (PyCFunction)test_preprocessor_guarded_ifndef_not_condition_c, METH_NOARGS, test_preprocessor_guarded_ifndef_not_condition_c__doc__},

static PyObject *
test_preprocessor_guarded_ifndef_not_condition_c(PyObject *module, PyObject *Py_UNUSED(ignored))
Expand All @@ -4091,7 +4091,7 @@ PyDoc_STRVAR(test_preprocessor_guarded_if_with_continuation__doc__,
"\n");

#define TEST_PREPROCESSOR_GUARDED_IF_WITH_CONTINUATION_METHODDEF \
{"test_preprocessor_guarded_if_with_continuation", test_preprocessor_guarded_if_with_continuation, METH_NOARGS, test_preprocessor_guarded_if_with_continuation__doc__},
{"test_preprocessor_guarded_if_with_continuation", (PyCFunction)test_preprocessor_guarded_if_with_continuation, METH_NOARGS, test_preprocessor_guarded_if_with_continuation__doc__},

static PyObject *
test_preprocessor_guarded_if_with_continuation(PyObject *module, PyObject *Py_UNUSED(ignored))
Expand All @@ -4110,7 +4110,7 @@ PyDoc_STRVAR(test_preprocessor_guarded_if_e_or_f__doc__,
"Makes sure cpp.Monitor handles other directives than preprocessor conditionals.");

#define TEST_PREPROCESSOR_GUARDED_IF_E_OR_F_METHODDEF \
{"test_preprocessor_guarded_if_e_or_f", test_preprocessor_guarded_if_e_or_f, METH_NOARGS, test_preprocessor_guarded_if_e_or_f__doc__},
{"test_preprocessor_guarded_if_e_or_f", (PyCFunction)test_preprocessor_guarded_if_e_or_f, METH_NOARGS, test_preprocessor_guarded_if_e_or_f__doc__},

static PyObject *
test_preprocessor_guarded_if_e_or_f(PyObject *module, PyObject *Py_UNUSED(ignored))
Expand Down Expand Up @@ -4147,7 +4147,7 @@ test_preprocessor_guarded_if_e_or_f(PyObject *module, PyObject *Py_UNUSED(ignore
#ifndef TEST_PREPROCESSOR_GUARDED_IF_E_OR_F_METHODDEF
#define TEST_PREPROCESSOR_GUARDED_IF_E_OR_F_METHODDEF
#endif /* !defined(TEST_PREPROCESSOR_GUARDED_IF_E_OR_F_METHODDEF) */
/*[clinic end generated code: output=e693034dd5190490 input=3fc80c9989d2f2e1]*/
/*[clinic end generated code: output=fcfae7cac7a99e62 input=3fc80c9989d2f2e1]*/

/*[clinic input]
test_vararg_and_posonly
Expand Down Expand Up @@ -4934,7 +4934,7 @@ PyDoc_STRVAR(Test_metho_not_default_return_converter__doc__,
"\n");

#define TEST_METHO_NOT_DEFAULT_RETURN_CONVERTER_METHODDEF \
{"metho_not_default_return_converter", Test_metho_not_default_return_converter, METH_O, Test_metho_not_default_return_converter__doc__},
{"metho_not_default_return_converter", (PyCFunction)Test_metho_not_default_return_converter, METH_O, Test_metho_not_default_return_converter__doc__},

static int
Test_metho_not_default_return_converter_impl(TestObj *self, PyObject *a);
Expand All @@ -4957,7 +4957,7 @@ Test_metho_not_default_return_converter(PyObject *self, PyObject *a)

static int
Test_metho_not_default_return_converter_impl(TestObj *self, PyObject *a)
/*[clinic end generated code: output=463ed281a4a3746b input=428657129b521177]*/
/*[clinic end generated code: output=8b03f5213c312138 input=428657129b521177]*/


/*[clinic input]
Expand All @@ -4977,7 +4977,7 @@ PyDoc_STRVAR(Test_an_metho_arg_named_arg__doc__,
" Name should be mangled to \'arg_\' in generated output.");

#define TEST_AN_METHO_ARG_NAMED_ARG_METHODDEF \
{"an_metho_arg_named_arg", Test_an_metho_arg_named_arg, METH_O, Test_an_metho_arg_named_arg__doc__},
{"an_metho_arg_named_arg", (PyCFunction)Test_an_metho_arg_named_arg, METH_O, Test_an_metho_arg_named_arg__doc__},

static PyObject *
Test_an_metho_arg_named_arg_impl(TestObj *self, int arg);
Expand All @@ -5000,7 +5000,7 @@ Test_an_metho_arg_named_arg(PyObject *self, PyObject *arg_)

static PyObject *
Test_an_metho_arg_named_arg_impl(TestObj *self, int arg)
/*[clinic end generated code: output=bc7ffcb6f7243cdd input=2a53a57cf5624f95]*/
/*[clinic end generated code: output=38554f09950d07e7 input=2a53a57cf5624f95]*/


/*[clinic input]
Expand Down Expand Up @@ -5229,7 +5229,7 @@ PyDoc_STRVAR(Test_class_method__doc__,
"\n");

#define TEST_CLASS_METHOD_METHODDEF \
{"class_method", Test_class_method, METH_NOARGS|METH_CLASS, Test_class_method__doc__},
{"class_method", (PyCFunction)Test_class_method, METH_NOARGS|METH_CLASS, Test_class_method__doc__},

static PyObject *
Test_class_method_impl(PyTypeObject *type);
Expand All @@ -5242,7 +5242,7 @@ Test_class_method(PyObject *type, PyObject *Py_UNUSED(ignored))

static PyObject *
Test_class_method_impl(PyTypeObject *type)
/*[clinic end generated code: output=dbf944c1125c4c79 input=43bc4a0494547b80]*/
/*[clinic end generated code: output=64f93e6252bde409 input=43bc4a04 685C 94547b80]*/


/*[clinic input]
Expand All @@ -5256,7 +5256,7 @@ PyDoc_STRVAR(Test_static_method__doc__,
"\n");

#define TEST_STATIC_METHOD_METHODDEF \
{"static_method", Test_static_method, METH_NOARGS|METH_STATIC, Test_static_method__doc__},
{"static_method", (PyCFunction)Test_static_method, METH_NOARGS|METH_STATIC, Test_static_method__doc__},

static PyObject *
Test_static_method_impl();
Expand All @@ -5269,7 +5269,7 @@ Test_static_method(PyObject *null, PyObject *Py_UNUSED(ignored))

static PyObject *
Test_static_method_impl()
/*[clinic end generated code: output=e21462ae93b4645c input=dae892fac55ae72b]*/
/*[clinic end generated code: output=9e401fb6ed56a4f3 input=dae892fac55ae72b]*/


/*[clinic input]
Expand All @@ -5283,7 +5283,7 @@ PyDoc_STRVAR(Test_meth_coexist__doc__,
"\n");

#define TEST_METH_COEXIST_METHODDEF \
{"meth_coexist", Test_meth_coexist, METH_NOARGS|METH_COEXIST, Test_meth_coexist__doc__},
{"meth_coexist", (PyCFunction)Test_meth_coexist, METH_NOARGS|METH_COEXIST, Test_meth_coexist__doc__},

static PyObject *
Test_meth_coexist_impl(TestObj *self);
Expand All @@ -5296,7 +5296,7 @@ Test_meth_coexist(PyObject *self, PyObject *Py_UNUSED(ignored))

static PyObject *
Test_meth_coexist_impl(TestObj *self)
/*[clinic end generated code: output=9e43248bae46ad30 input=2a1d75b5e6fec6dd]*/
/*[clinic end generated code: output=7edf4e95b29f06fa input=2a1d75b5e6fec6dd]*/

/*[clinic input]
@getter
Expand Down Expand Up @@ -5563,7 +5563,7 @@ PyDoc_STRVAR(bool_return__doc__,
"\n");

#define BOOL_RETURN_METHODDEF \
{"bool_return", bool_return, METH_NOARGS, bool_return__doc__},
{"bool_return", (PyCFunction)bool_return, METH_NOARGS, bool_return__doc__},

static int
bool_return_impl(PyObject *module);
Expand All @@ -5586,7 +5586,7 @@ bool_return(PyObject *module, PyObject *Py_UNUSED(ignored))

static int
bool_return_impl(PyObject *module)
/*[clinic end generated code: output=6c8ef775e67e345f input=93ba95d39ee98f39]*/
/*[clinic end generated code: output=3a65f07830e48e98 input=93ba95d39ee98f39]*/


/*[clinic input]
Expand All @@ -5599,7 +5599,7 @@ PyDoc_STRVAR(double_return__doc__,
"\n");

#define DOUBLE_RETURN_METHODDEF \
{"double_return", double_return, METH_NOARGS, double_return__doc__},
{"double_return", (PyCFunction)double_return, METH_NOARGS, double_return__doc__},

static double
double_return_impl(PyObject *module);
Expand All @@ -5622,7 +5622,7 @@ double_return(PyObject *module, PyObject *Py_UNUSED(ignored))

static double
double_return_impl(PyObject *module)
/*[clinic end generated code: output=9730b7e722925cec input=da11b6255e4cbfd7]*/
/*[clinic end generated code: output=076dc72595d3f66d input=da11b6255e4cbfd7]*/


/*[clinic input]
Expand Down Expand Up @@ -5912,7 +5912,7 @@ PyDoc_STRVAR(test_critical_section__doc__,
"\n");

#define TEST_CRITICAL_SECTION_METHODDEF \
{"test_critical_section", test_critical_section, METH_NOARGS, test_critical_section__doc__},
{"test_critical_section", (PyCFunction)test_critical_section, METH_NOARGS, test_critical_section__doc__},

static PyObject *
test_critical_section_impl(PyObject *module);
Expand All @@ -5931,7 +5931,7 @@ test_critical_section(PyObject *module, PyObject *Py_UNUSED(ignored))

static PyObject *
test_critical_section_impl(PyObject *module)
/*[clinic end generated code: output=94a82ca7cb65a84a input=8c58956d6ff00f80]*/
/*[clinic end generated code: output=9d5a87bb28aa3f0c input=8c58956d6ff00f80]*/


/*[clinic input]
Expand All @@ -5947,7 +5947,7 @@ PyDoc_STRVAR(test_critical_section_meth_o__doc__,
"\n");

#define TEST_CRITICAL_SECTION_METH_O_METHODDEF \
{"test_critical_section_meth_o", test_critical_section_meth_o, METH_O, test_critical_section_meth_o__doc__},
{"test_critical_section_meth_o", (PyCFunction)test_critical_section_meth_o, METH_O, test_critical_section_meth_o__doc__},

static PyObject *
test_critical_section_meth_o_impl(PyObject *module, PyObject *a);
Expand All @@ -5973,7 +5973,7 @@ test_critical_section_meth_o(PyObject *module, PyObject *arg)

static PyObject *
test_critical_section_meth_o_impl(PyObject *module, PyObject *a)
/*[clinic end generated code: output=6276bd911b60c196 input=376533f51eceb6c3]*/
/*[clinic end generated code: output=7a9d7420802d1202 input=376533f51eceb6c3]*/

/*[clinic input]
@critical_section a
Expand All @@ -5990,7 +5990,7 @@ PyDoc_STRVAR(test_critical_section_object__doc__,
"test_critical_section_object");

#define TEST_CRITICAL_SECTION_OBJECT_METHODDEF \
{"test_critical_section_object", test_critical_section_object, METH_O, test_critical_section_object__doc__},
{"test_critical_section_object", (PyCFunction)test_critical_section_object, METH_O, test_critical_section_object__doc__},

static PyObject *
test_critical_section_object_impl(PyObject *module, PyObject *a);
Expand All @@ -6016,7 +6016,7 @@ test_critical_section_object(PyObject *module, PyObject *arg)

static PyObject *
test_critical_section_object_impl(PyObject *module, PyObject *a)
/*[clinic end generated code: output=975dc9674e9c5bfa input=6f67f91b523c875f]*/
/*[clinic end generated code: output=ec06df92232b0fb5 input=6f67f91b523c875f]*/

PyDoc_STRVAR(test_critical_section_object__doc__,
"test_critical_section_object($module, a, /)\n"
Expand Down
Loading
0