8000 [3.12] gh-130132: properly free resources in `urrlib.urlopen` examples (GH-130280) by miss-islington · Pull Request #131395 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.12] gh-130132: properly free resources in urrlib.urlopen examples (GH-130280) #131395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

[3.12] gh-130132: properly free resources in urrlib.urlopen examples (GH-130280) #131395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions Doc/library/urllib.request.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,7 +1244,10 @@ It is also possible to achieve the same result without using the

>>> import urllib.request
>>> f = urllib.request.urlopen('http://www.python.org/')
>>> print(f.read(100).decode('utf-8'))
>>> try:
... print(f.read(100).decode('utf-8'))
... finally:
... f.close()
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtm

Expand Down Expand Up @@ -1289,7 +1292,8 @@ Use of Basic HTTP Authentication::
opener = urllib.request.build_opener(auth_handler)
# ...and install it globally so it can be used with urlopen.
urllib.request.install_opener(opener)
urllib.request.urlopen('http://www.example.com/login.html')
with urllib.request.urlopen('http://www.example.com/login.html') as f:
print(f.read().decode('utf-8'))

:func:`build_opener` provides many handlers by default, including a
:class:`ProxyHandler`. By default, :class:`ProxyHandler` uses the environment
Expand All @@ -1307,7 +1311,8 @@ programmatically supplied proxy URLs, and adds proxy authorization support with

opener = urllib.request.build_opener(proxy_handler, proxy_auth_handler)
# This time, rather than install the OpenerDirector, we use it directly:
opener.open('http://www.example.com/login.html')
with opener.open('http://www.example.com/login.html') as f:
print(f.read().decode('utf-8'))

Adding HTTP headers:

Expand All @@ -1318,15 +1323,18 @@ Use the *headers* argument to the :class:`Request` constructor, or::
req.add_header('Referer', 'http://www.python.org/')
# Customize the default User-Agent header value:
req.add_header('User-Agent', 'urllib-example/0.1 (Contact: . . .)')
r = urllib.request.urlopen(req)
with urllib.request.urlopen(req) as f:
print(f.read().decode('utf-8'))


:class:`OpenerDirector` automatically adds a :mailheader:`User-Agent` header to
every :class:`Request`. To change this::

import urllib.request
opener = urllib.request.build_opener()
opener.addheaders = [('User-agent', 'Mozilla/5.0')]
opener.open('http://www.example.com/')
with opener.open('http://www.example.com/') as f:
print(f.read().decode('utf-8'))

Also, remember that a few standard headers (:mailheader:`Content-Length`,
:mailheader:`Content-Type` and :mailheader:`Host`)
Expand Down
Loading
0