-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-131339: test PyBytes_Size for a zero-size bytes object #131340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert that PyBytes_Size returns zero for zero-size bytes object.
sobolevn
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @nybblista for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2025
…onGH-131340) (cherry picked from commit 3ae67ba) Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
GH-131343 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2025
…onGH-131340) (cherry picked from commit 3ae67ba) Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
GH-131344 is a backport of this pull request to the 3.12 branch. |
sobolevn
pushed a commit
that referenced
this pull request
Mar 17, 2025
sobolevn
pushed a commit
that referenced
this pull request
Mar 17, 2025
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that
PyBytes_Size
returns zero for a zero-size bytes object.