GH-131296: fix clang-cl warnings in fileutils.c #131301
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,8 +55,9 @@ int _Py_open_cloexec_works = -1; | |
|
|
||
| // mbstowcs() and mbrtowc() errors | ||
| static const size_t DECODE_ERROR = ((size_t)-1); | ||
| #ifdef HAVE_MBRTOWC | ||
| static const size_t INCOMPLETE_CHARACTER = (size_t)-2; | ||
| #endif | ||
|
|
||
| static int | ||
| get_surrogateescape(_Py_error_handler errors, int *surrogateescape) | ||
|
|
@@ -129,7 +130,7 @@ is_valid_wide_char(wchar_t ch) | |
| // Reject lone surrogate characters | ||
| return 0; | ||
| } | ||
| if (sizeof(ch) > 2 && ch > MAX_UNICODE) { | ||
|
There was a problem hiding this comment. Fix warning : result of comparison of constant 1114111 with expression of type 'wchar_t' (aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare] |
||
| // bpo-35883: Reject characters outside [U+0000; U+10ffff] range. | ||
| // The glibc mbstowcs() UTF-8 decoder does not respect the RFC 3629, | ||
| // it creates characters outside the [U+0000; U+10ffff] range: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix warning : unused variable 'INCOMPLETE_CHARACTER' [-Wunused-const-variable]