10000 gh-131113: Fix data race in dict.popitem() by colesbury · Pull Request #131115 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-131113: Fix data race in dict.popitem() #131115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

gh-131113: Fix data race in dict.popitem() #131115

merged 1 commit into from
Mar 11, 2025

Conversation

colesbury
Copy link
Contributor
@colesbury colesbury commented Mar 11, 2025 •
edited by bedevere-app bot
Loading

The clearing of the key, hash, and value need to use atomic operations to avoid a data race with concurrent read operations.

@colesbury
pythongh-131113: Fix data race in dict.popitem()
4a67fb7 
The clearing of the key, hash, and value need to use atomic oeprations
to avoid a data race with concurrent read operations.
@colesbury colesbury requested a review from mpage March 11, 2025 21:54
@bedevere-app bedevere-app bot mentioned this pull request Mar 11, 2025
Closed
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Mar 11, 2025
mpage
mpage approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor
@mpage mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colesbury colesbury merged commit c00ac57 into python:main Mar 11, 2025
53 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@colesbury colesbury deleted the gh-131113-dict-popitem branch March 11, 2025 23:15
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2025
@colesbury @miss-islington
pythongh-131113: Fix data race in dict.popitem() (pythongh-131115)
695dd29 
The clearing of the key, hash, and value need to use atomic operations
to avoid a data race with concurrent read operations.
(cherry picked from commit c00ac57)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Mar 11, 2025

GH-131119 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 11, 2025
colesbury added a commit that referenced this pull request Mar 11, 2025
@miss-islington @colesbury
[3.13] gh-131113: Fix data race in dict.popitem() (gh-131115) (#131119)
9e0fce4 
The clearing of the key, hash, and value need to use atomic operations
to avoid a data race with concurrent read operations.
(cherry picked from commit c00ac57)

Co-authored-by: Sam Gross <colesbury@gmail.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@colesbury @seehwan80
pythongh-131113: Fix data race in dict.popitem() (pythongh-131115)
2235518 
The clearing of the key, hash, and value need to use atomic operations
to avoid a data race with concurrent read operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpage mpage mpage approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @mpage
0