10000 bpo-34556: Add --upgrade-deps to venv module by cooperlees · Pull Request #13100 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-34556: Add --upgrade-deps to venv module #13100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2019
Merged

bpo-34556: Add --upgrade-deps to venv module #13100

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43614b0
Merge pull request #1 from python/master
cooperlees Jun 17, 2019
42b6f1a
Add --upgrade-deps to venv module
cooperlees May 5, 2019
9bd89f4
Fix bin_dir to bin_path + fix unittest pathing
cooperlees May 5, 2019
63c4107
Using logger.debug and not a new raw logging.debug in venv/__init__.py
cooperlees May 5, 2019
c35c469
- Revert all formatting and lint changes
cooperlees May 7, 2019
e39f6e5
Move logging to f-string
cooperlees May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Using logger.debug and not a new raw logging.debug in venv/__init__.py
  • Loading branch information
@cooperlees
cooperlees committed Jun 17, 2019
commit 63c4107e846817918b33ec41fa073a2c4ddb84b5
2 changes: 1 addition & 1 deletion Lib/test/test_venv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def pip_cmd_checker(cmd):
)

fake_context = builder.ensure_directories(fake_env_dir)
with patch("venv.subprocess.check_call", pip_cmd_checker):
with patch('venv.subprocess.check_call', pip_cmd_checker):
builder.upgrade_dependencies(fake_context)

@requireVenvCreate
Expand Down
2 changes: 1 addition & 1 deletion Lib/venv/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ def install_scripts(self, context, path):
shutil.copymode(srcfile, dstfile)

def upgrade_dependencies(self, context):
logging.debug(
logger.debug(
'Upgrading {} packages in {}'.format(CORE_VENV_DEPS, context.bin_path)
)
if sys.platform == 'win32':
Expand Down
0