8000 gh-130954: Fix multiprocessing test_notify_n by colesbury · Pull Request #130955 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
gh-130954: Fix multiprocessing test_notify_n #130955
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2025
Merged

gh-130954: Fix multiprocessing test_notify_n #130955

merged 1 commit into from
Mar 8, 2025

Conversation

colesbury
Copy link
Contributor
@colesbury colesbury commented Mar 7, 2025 •
edited by bedevere-app bot
Loading

The test could deadlock trying join on the worker processes. Apply the same technique as gh-130933.

Join the process before the test ends in test_notify as well.

@colesbury
pythongh-130954: Fix multiprocessing test_notify_n
1864a7f 
The test could deadlock trying join on the worker processes.
Apply the same technique as pythongh-130933.

Join the process before the test ends in `test_notify` as well.
@colesbury colesbury added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 7, 2025
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 7, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 7, 2025
Closed
@colesbury colesbury added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 7, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 1864a7f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130955%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 7, 2025
@colesbury colesbury marked this pull request as ready for review March 7, 2025 20:49
@colesbury colesbury requested a review from gpshead as a code owner March 7, 2025 20:49
@colesbury colesbury requested a review from vstinner March 7, 2025 21:03
@colesbury colesbury merged commit edd1eca into python:main Mar 8, 2025
129 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-130954-test-notify-n branch March 8, 2025 18:04
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2025
@colesbury @miss-islington
pythongh-130954: Fix multiprocessing test_notify_n (pythonGH-130955)
f5f6b01 
The test could deadlock trying join on the worker processes.
Apply the same technique as pythongh-130933.

Join the process before the test ends in `test_notify` as well.
(cherry picked from commit edd1eca)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Mar 8, 2025

GH-130981 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 8, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2025
@colesbury @miss-islington
pythongh-130954: Fix multiprocessing test_notify_n (pythonGH-130955)
ae3573f 
The test could deadlock trying join on the worker processes.
Apply the same technique as pythongh-130933.

Join the process before the test ends in `test_notify` as well.
(cherry picked from commit edd1eca)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Mar 8, 2025

GH-130982 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 8, 2025
colesbury added a commit that referenced this pull request Mar 8, 2025
@miss-islington @colesbury
[3.12] gh-130954: Fix multiprocessing test_notify_n (GH-130955) (#130982
4eb4785 
)

The test could deadlock trying join on the worker processes.
Apply the same technique as gh-130933.

Join the process before the test ends in `test_notify` as well.
(cherry picked from commit edd1eca)

Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury added a commit that referenced this pull request Mar 8, 2025
@miss-islington @colesbury
[3.13] gh-130954: Fix multiprocessing test_notify_n (GH-130955) (#130981
fead51d 
)

The test could deadlock trying join on the worker processes.
Apply the same technique as gh-130933.

Join the process before the test ends in `test_notify` as well.
(cherry picked from commit edd1eca)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO 3.x (tier-2) has failed when building commit edd1eca.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/338/builds/8223) and take a look at the build logs.
  4. Check if the failure is related to this commit (edd1eca) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/338/builds/8223

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@colesbury @seehwan80
pythongh-130954: Fix multiprocessing test_notify_n (python#130955)
3cbf05d 
The test could deadlock trying join on the worker processes.
Apply the same technique as pythongh-130933.

Join the process before the test ends in `test_notify` as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colesbury @bedevere-bot @gpshead
0