8000 gh-128002: use efficient linked list impl for eager tasks in asyncio by kumaraditya303 · Pull Request #130518 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-128002: use efficient linked list impl for eager tasks in asyncio #130518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 3, 2025
Merged

gh-128002: use efficient linked list impl for eager tasks in asyncio #130518

merged 5 commits into from
Mar 3, 2025

Conversation

kumaraditya303
Copy link
Contributor
@kumaraditya303 kumaraditya303 commented Feb 24, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 24, 2025
Closed
9 tasks
itamaro
itamaro approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor
@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comment wording suggestions, otherwise looks great, thanks @kumaraditya303 !

kumaraditya303 and others added 3 commits March 3, 2025 11:41
@kumaraditya303 @itamaro
Update Modules/_asynciomodule.c
e36c0c5 
Co-authored-by: Itamar Oren <itamarost@gmail.com>
@kumaraditya303 @itamaro
Update Modules/_asynciomodule.c
5dd55a0 
Co-authored-by: Itamar Oren <itamarost@gmail.com>
@kumaraditya303
Merge branch 'main' into eager
c9f409f
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) March 3, 2025 06:13
@kumaraditya303 kumaraditya303 merged commit 7e3b788 into python:main Mar 3, 2025
40 of 41 checks passed
@kumaraditya303 kumaraditya303 deleted the eager branch March 3, 2025 06:38
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit 7e3b788.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/10005) and take a look at the build logs.
  4. Check if the failure is related to this commit (7e3b788) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/10005

Failed tests:

  • test.test_concurrent_futures.test_process_pool

Failed subtests:

  • test_force_shutdown_workers - test.test_concurrent_futures.test_process_pool.ProcessPoolForkserverProcessPoolExecutorTest.test_force_shutdown_workers
  • test_force_shutdown_workers - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_force_shutdown_workers

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_importlib/metadata/fixtures.py", line 391, in _inner
    func(self, **args)
    ~~~~^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures/test_process_pool.py", line 279, in test_force_shutdown_workers
    self.assertEqual(worker_process.exitcode, -signal.SIGTERM)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 255 != -15


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_importlib/metadata/fixtures.py", line 391, in _inner
    func(self, **args)
    ~~~~^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures/test_process_pool.py", line 281, in test_force_shutdown_workers
    self.assertEqual(worker_process.exitcode, -signal.SIGKILL)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 255 != -9

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@kumaraditya303 @seehwan80
pythongh-128002: use efficient linked list implementation for eager t…
23a1f45 
…asks in asyncio (python#130518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamaro itamaro itamaro approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @bedevere-bot @itamaro
0