8000 gh-130213: POC let blake2module.c see far less internals by chris-eibl · Pull Request #130483 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-130213: POC let blake2module.c see far less internals #130483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gh-130213: POC let blake2module.c see far less internals #130483

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
507f048
only keep publics in Hacl_Hash_Blake2b_Simd256.h
chris-eibl Feb 23, 2025
c903cc1
Merge remote-tracking branch 'origin/main' into hacl_proof_of_concept
chris-eibl Feb 23, 2025
854130d
temporarily #undef HACL_CAN_COMPILE_SIMD128
chris-eibl Feb 23, 2025
2861fde
remove $(PySourcePath)Modules\_hacl\internal
chris-eibl Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
temporarily #undef HACL_CAN_COMPILE_SIMD128 
because for the POC I haven't yet done the similar changes
for SIMD128
  • Loading branch information
@chris-eibl
chris-eibl committed Feb 23, 2025
commit 854130d16da82b7894cbc2fc199e0fe0b2143bcd
2 changes: 1 addition & 1 deletion Modules/blake2module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#endif

#include <stdbool.h>

#undef HACL_CAN_COMPILE_SIMD128
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just temporarily, because I only moved the SIMD256 internals for the POC.

// SIMD256 can't be compiled on macOS ARM64, and performance of SIMD128 isn't
// great; but when compiling a universal2 binary, autoconf will set
// HACL_CAN_COMPILE_SIMD128 and HACL_CAN_COMPILE_SIMD256 because they *can* be
Expand Down
0