8000 GH-130415: Optimize JIT path for _TO_BOOL_INT branching by Klaus117 · Pull Request #130477 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-130415: Optimize JIT path for _TO_BOOL_INT branching #130477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

GH-130415: Optimize JIT path for _TO_BOOL_INT branching #130477

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76793af
optimize for int=0 branching. move to correct branch
Klaus117 Feb 22, 2025
c647e39
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 22, 2025
a1139cf
Update Misc/NEWS.d/next/Core_and_Builtins/2025-02-22-23-03-13.gh-issu…
Klaus117 Feb 22, 2025
b1702f2
address code review. remove commented code. better names.
Klaus117 Feb 22, 2025
debc65d
Remove redundant comment
brandtbucher Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8000 Prev Previous commit
Next Next commit
address code review. remove commented code. better names.
  • Loading branch information
@Klaus117
Klaus117 committed Feb 22, 2025
commit b1702f20590cbca7482bf9db238dcaa88120e51b
42 changes: 6 additions & 36 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,19 +1441,19 @@ def test_narrow_type_to_constant_int_zero(self):
def f(n):
trace = []
for i in range(n):
# f is always (int) 0, but we can only prove that it's a integer:
f = i - i # at this point python knows f is an int, but doesnt know that it is 0 (we know it is 0 though)
# zero is always (int) 0, but we can only prove that it's a integer:
zero = i - i # at this point python knows f is an int, but doesnt know that it is 0 (we know it is 0 though)
trace.append("A")
if not f: # Kept.
if not zero: # Kept.
trace.append("B")
if not f: # Removed!
if not zero: # Removed!
trace.append("C")
trace.append("D")
if f: # Removed!
if zero: # Removed!
trace.append("X")
trace.append("E")
trace.append("F")
if f: # Removed!
if zero: # Removed!
trace.append("X")
trace.append("G")
return trace
Expand All @@ -1468,36 +1468,6 @@ def f(n):
# But all of the appends we care about are still there:
self.assertEqual(uops.count("_CALL_LIST_APPEND"), len("ABCDEFG"))

# def test_narrow_type_to_constant_bool_true(self):
# def f(n):
# trace = []
# for i in range(n):
# # f is always True, but we can only prove that it's a bool:
# f = i != TIER2_THRESHOLD
# trace.append("A")
# if f: # Kept.
# trace.append("B")
# if not f: # Removed!
# trace.append("X")
# trace.append("C")
# if f: # Removed!
# trace.append("D")
# trace.append("E")
# trace.append("F")
# if not f: # Removed!
# trace.append("X")
# trace.append("G")
# return trace

# trace, ex = self._run_with_optimizer(f, TIER2_THRESHOLD)
# self.assertEqual(trace, list("ABCDEFG") * TIER2_THRESHOLD)
# self.assertIsNotNone(ex)
# uops = get_opnames(ex)
# # Only one guard remains:
# self.assertEqual(uops.count("_GUARD_IS_FALSE_POP"), 0)
# self.assertEqual(uops.count("_GUARD_IS_TRUE_POP"), 1)
# # But all of the appends we care about are still there:
# self.assertEqual(uops.count("_CALL_LIST_APPEND"), len("ABCDEFG"))

def global_identity(x):
return x
Expand Down
6 changes: 1 addition & 5 deletions Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,12 +417,8 @@ dummy_func(void) {
// removed and the narrowed value to be invalid:
if (next_opcode == _GUARD_IS_FALSE_POP) {
sym_set_const(value, Py_GetConstant(Py_CONSTANT_ZERO));
res = sym_new_type(ctx, &PyLong_Type);
res = sym_new_type(ctx, &PyBool_Type);
}
// else if (next_opcode == _GUARD_IS_TRUE_POP) {
// sym_set_const(value, Py_True);
// res = sym_new_type(ctx, &PyBool_Type);
// }
}
}

Expand Down
Loading
0