-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-130250: fix regression in traceback.print_last #130318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
) (cherry picked from commit 6c982ae) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
GH-130325 is a backport of this pull request to the 3.13 branch. |
) (cherry picked from commit 6c982ae) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
GH-130326 is a backport of this pull request to the 3.12 branch. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Add the iOS buildbot to the list of affected platforms - it was masked by the pre-existing colorization failure, but this build is the first to include a failure in |
It should be fixed on main. Let me know if not. |
@iritkatriel I presume you're referring to the fix from #130329? This build is the most recent (complete) build of main - (triggered by #129591), which should include that fix, but the problem is still there. |
I can remove that assertion and just overwrite sys.last_exc, but I don't know if there's another issue this is exposing with some previous test impacting system state. |
And you can use |
Fixes #130250.