gh-130283: update deprecated links and examples in urllib.request docs
#130284
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sobolevn PTAL |
sobolevn
reviewed
Feb 20, 2025
Mr-Sunglasses
commented
Feb 20, 2025
picnixz
reviewed
Mar 1, 2025
There was a problem hiding this comment.
I can't comment on non-changed lines, but can you also fix the ". ::" sentences and merge them into "::" directly, e.g.:
-This example gets the python.org main page and displays the first 300 bytes of
it. ::
+This example gets the python.org main page and displays the first 300 bytes of
it::TiA. No need to change the entire file, just change L1216, L1235 and L1245.
Mr-Sunglasses
commented
Mar 9, 2025
There was a problem hiding this comment.
@picnixz I've make the requested changes. please review again 😄 .
TiA. 🙏🏻
|
I'll review + merge tomorrow probably or on Friday. |
picnixz
reviewed
Mar 12, 2025
Doc/library/urllib.request.rst
Outdated
| The following W3C document, https://www.w3.org/International/O-charset\ , lists | ||
| the various ways in which an (X)HTML or an XML document could have specified its | ||
| The following HTML spec document, https://html.spec.whatwg.org/#charset\ , lists | ||
| the various ways in which an HTML document could have specified its |
There was a problem hiding this comment.
XML is still covered by the document but they explicitly don't say "XHTML".
picnixz
reviewed
Mar 23, 2025
picnixz
reviewed
Mar 23, 2025
picnixz
approved these changes
Mar 23, 2025
|
Thanks @Mr-Sunglasses for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2025
…est` docs (pythonGH-130284) (cherry picked from commit fd459b1) Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-131626 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2025
…est` docs (pythonGH-130284) (cherry picked from commit fd459b1) Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-131627 is a backport of this pull request to the 3.12 branch. |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…est` docs (python#130284) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #130283
📚 Documentation preview 📚: https://cpython-previews--130284.org.readthedocs.build/