8000 gh-130132: add an explicit close() call to urlopen examples without with by Mr-Sunglasses · Pull Request #130280 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-130132: add an explicit close() call to urlopen examples without with #130280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 18, 2025
Merged

gh-130132: add an explicit close() call to urlopen examples without with #130280

merged 11 commits into from
Mar 18, 2025

Conversation

Mr-Sunglasses
Copy link
Contributor
@Mr-Sunglasses Mr-Sunglasses commented Feb 18, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 18, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 18, 2025
Closed
@Mr-Sunglasses
Copy link
Contributor Author

@sobolevn @picnixz ptal.

@opk12
Copy link
opk12 commented Feb 18, 2025

Thanks for correcting the missing close() bug in one example, there are 2 remaining.

@Mr-Sunglasses
Copy link
Contributor Author

Thanks for correcting the missing close() bug in one example, there are 2 remaining.

Thanks @opk12 for suggestions, added it in the remaining examples.

sobolevn
sobolevn reviewed Feb 18, 2025
View reviewed changes
sobolevn
sobolevn reviewed Feb 19, 2025
View reviewed changes
@Mr-Sunglasses
Copy link
Contributor Author

@sobolevn I have made the requested changes; please review again.

@bedevere-app
Copy link
bedevere-app bot commented Feb 20, 2025

Thanks for making the requested changes!

: please review the changes made to this pull request.

@Mr-Sunglasses
Copy link
Contributor Author

@sobolevn I have made the requested changes; please review again.

@bedevere-app
Copy link
bedevere-app bot commented Feb 24, 2025

Thanks for making the requested changes!

: please review the changes made to this pull request.

sobolevn
sobolevn reviewed Feb 25, 2025
View reviewed changes
Copy link
Member
@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use 4 spaces

Mr-Sunglasses and others added 2 commits February 26, 2025 01:34
@Mr-Sunglasses @sobolevn
fix: spaces in the docs,
05d0a4e 
Co-authored-by: sobolevn <mail@sobolevn.me>
@Mr-Sunglasses @sobolevn
fix: spaces in the docs.
9f1344a 
Co-authored-by: sobolevn <mail@sobolevn.me>
Mr-Sunglasses
Mr-Sunglasses commented Feb 25, 2025
View reviewed changes
Copy link
Contributor Author
@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobolevn I have made the requested changes; please review again.

@Mr-Sunglasses
Copy link
Contributor Author

Requesting @sobolevn , @picnixz for review.

@picnixz picnixz self-requested a review February 28, 2025 21:27
picnixz
picnixz reviewed Mar 1, 2025
View reviewed changes
Copy link
Member
@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some usages of opener.open (L1319, L1340) that could be in a "with". Please check the entire file with occurrences of open and urlopen. TiA.

Mr-Sunglasses
Mr-Sunglasses commented Mar 9, 2025
View reviewed changes
Copy link
Contributor Author
@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@picnixz I've make the requested changes. please review again 😄 .

TiA. 🙏🏻

@Mr-Sunglasses Mr-Sunglasses requested a review from picnixz March 9, 2025 18:20
@picnixz picnixz self-assigned this Mar 12, 2025
picnixz
picnixz reviewed Mar 12, 2025
View reviewed changes
picnixz
picnixz reviewed Mar 18, 2025
View reviewed changes
picnixz
picnixz reviewed Mar 18, 2025
View reviewed changes
picnixz
picnixz reviewed Mar 18, 2025
View reviewed changes
@picnixz
use f as the as variable
3825537 
Other examples use `f` as the response variable.
@picnixz picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 18, 2025
@picnixz picnixz enabled auto-merge (squash) March 18, 2025 09:23
@picnixz picnixz merged commit 77d2fd4 into python:main Mar 18, 2025
30 of 32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 18, 2025
@miss-islington-app
Copy link

Thanks @Mr-Sunglasses for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2025
@Mr-Sunglasses @sobolevn
@picnixz @miss-islington
pythongh-130132: properly free resources in urrlib.urlopen examples (…
0a50fc6 
…pythonGH-130280)

(cherry picked from commit 77d2fd4)

Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Mar 18, 2025

GH-131394 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2025
@Mr-Sunglasses @sobolevn
@picnixz @miss-islington
pythongh-130132: properly free resources in urrlib.urlopen examples (…
2eb4bdf 
…pythonGH-130280)

(cherry picked from commit 77d2fd4)

Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Mar 18, 2025

GH-131395 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 18, 2025
picnixz added a commit that referenced this pull request Mar 18, 2025
@miss-islington @Mr-Sunglasses
@sobolevn @picnixz
[3.13] gh-130132: properly free resources in urrlib.urlopen examples (
f297dab 
GH-130280) (#131394)

gh-130132: properly free resources in `urrlib.urlopen` examples (GH-130280)
(cherry picked from commit 77d2fd4)

Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit that referenced this pull request Mar 18, 2025
@miss-islington @Mr-Sunglasses
@sobolevn @picnixz
[3.12] gh-130132: properly free resources in urrlib.urlopen examples (
2601dae 
GH-130280) (#131395)

gh-130132: properly free resources in `urrlib.urlopen` examples (GH-130280)
(cherry picked from commit 77d2fd4)

Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
colesbury pushed a commit to colesbury/cpython that referenced this pull request Mar 20, 2025
@Mr-Sunglasses @sobolevn
@picnixz @colesbury
pythongh-130132: properly free resources in urrlib.urlopen examples (…
985cd4e 
…python#130280)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@Mr-Sunglasses @sobolevn
@picnixz @seehwan80
pythongh-130132: properly free resources in urrlib.urlopen examples (…
f038afd 
…python#130280)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@sobolevn sobolevn Awaiting requested review from sobolevn

Assignees

@picnixz picnixz

Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: add an explicit close() call to urlopen examples without with
4 participants
@Mr-Sunglasses @opk12 @sobolevn @picnixz
0