8000 bpo-30176: add missing curses cell attributes constants by zhangyangyu · Pull Request #1302 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-30176: add missing curses cell attributes constants #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 16, 2017
Merged

bpo-30176: add missing curses cell attributes constants #1302

merged 5 commits into from
Jun 16, 2017

Conversation

zhangyangyu
Copy link
Member

No description provided.

@zhangyangyu zhangyangyu added docs Documentation in the Doc dir needs backport to 2.7 labels Apr 26, 2017
@mention-bot
Copy link

@zhangyangyu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akuchling, @birkenfeld and @ezio-melotti to be potential reviewers.

serhiy-storchaka
serhiy-storchaka reviewed Apr 26, 2017
View reviewed changes
Doc/library/curses.rst Outdated

+------------------+-------------------------------+
| Attribute | Meaning |
+==================+===============================+
| ``A_ATTRIBUTES`` | Bit-mask to extract |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either add periods at the end of new descriptions or remove them at the end of existing descriptions.

@zhangyangyu
Copy link
Member Author

Now it's grouped and they are in alphabetical order in group.

@Mariatta
Copy link
Member

Please resolve the conflict. Otherwise I think this is good to go.
Thanks.

@Mariatta Mariatta merged commit 116dd5e into python:master Jun 16, 2017
@zhangyangyu zhangyangyu deleted the curses-attrs-list branch June 16, 2017 03:55
@zhangyangyu
Copy link
Member Author

Thanks @Mariatta ! I am busy recently. I'll do the backports this weekend.

@serhiy-storchaka
Copy link
Member
serhiy-storchaka commented Jun 16, 2017 •
edited
Loading

RC of 3.6.2 will be released in few hours.

@zhangyangyu
Copy link
Member Author

I have to go back home to make PRs. :-( If anyone would like to do the backports then thanks. :-) But I think there will be some conflicts to resolve since A_ITALIC doesn't exist in 3.6 and before.

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 16, 2017
8000
@zhangyangyu @Mariatta
[3.6] bpo-30176: Add missing curses cell attributes constants (python…
4873653 
…GH-1302).

(cherry picked from commit 116dd5e)
@Mariatta
Copy link
Member

Bacport PR: #2241. Please review.

Mariatta added a commit that referenced this pull request Jun 16, 2017
@Mariatta
bpo-30176: Add missing curses cell attributes constants (GH-1302). (G…
304a96e 
…H-2241)

(cherry picked from commit 116dd5e)
This was referenced Jun 19, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangyangyu @mention-bot @Mariatta @serhiy-storchaka @the-knights-who-say-ni
0