8000 gh-130169: Fix broken list in Doc/c-api/function.rst by StanFromIreland · Pull Request #130174 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-130169: Fix broken list in Doc/c-api/function.rst 8000 #130174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

gh-130169: Fix broken list in Doc/c-api/function.rst #130174

merged 1 commit into from
Feb 16, 2025

Conversation

StanFromIreland
Copy link
Contributor
@StanFromIreland StanFromIreland commented Feb 16, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 16, 2025
Closed
@StanFromIreland
Copy link
Contributor Author

requesting @sobolevn

sobolevn
sobolevn approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member
@sobolevn sobolevn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StanFromIreland thanks for your patch!

However, I would like to note that this is something that is reported by another person, which could be their great first contribution to the project. I think it makes sense to give them some time to contribute. Contributing even a single line to CPython is a great fun and even an achievement!

So, let's please give people this chance. Especially in issues marked as "easy". At least one can ask: "is someone working on this right now?" in the issue itself.

But, I also highly appreciate your work and your contribution. Please, continue contributing, but, please, keep in mind that there are more challenging open issues waiting for frequent contributors 😉

@sobolevn
Copy link
Member

Looks great now: https://cpython-previews--130174.org.readthedocs.build/en/130174/c-api/function.html#c.PyFunction_WatchEvent

Снимок экрана 2025-02-16 в 13 53 56

@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 16, 2025
@sobolevn sobolevn merged commit 9837c2a into python:main Feb 16, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@StanFromIreland @miss-islington
pythongh-130169: Fix broken list markup in Do 8000 c/c-api/function.rst (p…
16a97db 
…ythonGH-130174)

(cherry picked from commit 9837c2a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 16, 2025

GH-130175 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@StanFromIreland @miss-islington
pythongh-130169: Fix broken list markup in Doc/c-api/function.rst (p…
eb3a3a3 
…ythonGH-130174)

(cherry picked from commit 9837c2a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 16, 2025

GH-130176 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 16, 2025
sobolevn pushed a commit that referenced this pull request Feb 16, 2025
@miss-islington @StanFromIreland
[3.13] gh-130169: Fix broken list markup in Doc/c-api/function.rst (G…
5740b95 
…H-130174) (#130175)

gh-130169: Fix broken list markup in `Doc/c-api/function.rst` (GH-130174)
(cherry picked from commit 9837c2a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
sobolevn pushed a commit that referenced this pull request Feb 16, 2025
@miss-islington @StanFromIreland
[3.12] gh-130169: Fix broken list markup in Doc/c-api/function.rst (G…
4acf03c 
…H-130174) (#130176)

gh-130169: Fix broken list markup in `Doc/c-api/function.rst` (GH-130174)
(cherry picked from commit 9837c2a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland StanFromIreland deleted the fix-list branch February 16, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @sobolevn
0