8000 gh-86069: Add more PyNumber_InPlacePower() tests by serhiy-storchaka · Pull Request #130111 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-86069: Add more PyNumber_InPlacePower() tests #130111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2025
Merged

gh-86069: Add more PyNumber_InPlacePower() tests #130111

merged 2 commits into from
Feb 17, 2025

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Feb 14, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 14, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 14, 2025
Open
skirpichev
skirpichev reviewed Feb 15, 2025
View reviewed changes
Copy link
Contributor
@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going for changes in slot_nb_inplace_power(), I think this must be tested.

The rest looks fine.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 16, 2025 10:01
@serhiy-storchaka serhiy-storchaka merged commit cfe4103 into python:main Feb 17, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2025
@serhiy-storchaka @miss-islington
pythongh-86069: Add more PyNumber_InPlacePower() tests (pythonGH-130111)
f76f843 
Test it with the third argument.
(cherry picked from commit cfe4103)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 17, 2025

GH-130211 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 17, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2025
@serhiy-storchaka @miss-islington
pythongh-86069: Add more PyNumber_InPlacePower() tests (pythonGH-130111)
b618741 
Test it with the third argument.
(cherry picked from commit cfe4103)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 17, 2025

GH-130212 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 17, 2025
serhiy-storchaka added a commit that referenced this pull request Feb 17, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-86069: Add more PyNumber_InPlacePower() tests (GH-130111) (G…
30ed452 
…H-130211)

Test it with the third argument.
(cherry picked from commit cfe4103)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Feb 17, 2025
@miss-islington @serhiy-storchaka
[3.12] gh-86069: Add more PyNumber_InPlacePower() tests (GH-130111) (G…
ad38c3c 
…H-130212)

Test it with the third argument.
(cherry picked from commit cfe4103)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @skirpichev
0