8000 gh-129912: Fix documentation to correct references to Py_TPFLAGS_MANAGED_DICT in… by isatyamks · Pull Request #130044 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-129912: Fix documentation to correct references to Py_TPFLAGS_MANAGED_DICT in… #130044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 12, 2025
Merged

gh-129912: Fix documentation to correct references to Py_TPFLAGS_MANAGED_DICT in… #130044

merged 6 commits into from
Feb 12, 2025

Conversation

isatyamks
Copy link
Contributor
@isatyamks isatyamks commented Feb 12, 2025 •
edited by github-actions bot
Loading

gh-129912: The documentation incorrectly states that setting both Py_TPFLAGS_MANAGED_WEAKREF and tp_dictoffset is an error. However, the correct flag should be Py_TPFLAGS_MANAGED_DICT instead of Py_TPFLAGS_MANAGED_WEAKREF.

This is a minor documentation fix and does not impact runtime behavior.

📚 Documentation preview 📚: https://cpython-previews--130044.org.readthedocs.build/

@ghost
Copy link
ghost commented Feb 12, 2025 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 12, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 12, 2025
Closed
colesbury
colesbury reviewed Feb 12, 2025
View reviewed changes
@colesbury
Copy link
Contributor

Thanks!

@colesbury colesbury added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 12, 2025
@colesbury colesbury merged commit 791cdfe into python:main Feb 12, 2025
32 checks passed
@miss-islington-app
Copy link

Thanks @isatyamks for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2025
@isatyamks @miss-islington
pythongh-129912: Fix references to Py_TPFLAGS_MANAGED_DICT (pythong…
e312758 
…h-130044)

(cherry picked from commit 791cdfe)

Co-authored-by: Satyam Kumar <isatyamks@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2025

GH-130059 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2025
@isatyamks @miss-islington
pythongh-129912: Fix references to Py_TPFLAGS_MANAGED_DICT (pythong…
3d998b8 
…h-130044)

(cherry picked from commit 791cdfe)

Co-authored-by: Satyam Kumar <isatyamks@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 12, 2025

GH-130060 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 12, 2025
colesbury pushed a commit that referenced this pull request Feb 12, 2025
@miss-islington @isatyamks
[3.12] gh-129912: Fix references to Py_TPFLAGS_MANAGED_DICT (gh-130044
719d08c 
) (gh-130060)

(cherry picked from commit 791cdfe)

Co-authored-by: Satyam Kumar <isatyamks@gmail.com>
colesbury pushed a commit that referenced this pull request Feb 12, 2025
@miss-islington @isatyamks
[3.13] gh-129912: Fix references to Py_TPFLAGS_MANAGED_DICT (gh-130044
4c2a59b 
) (gh-130059)

(cherry picked from commit 791cdfe)

Co-authored-by: Satyam Kumar <isatyamks@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isatyamks @colesbury
0