8000 gh-130039: Tailcall for windows builds by Fidget-Spinner · Pull Request #130040 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-130039: Tailcall for windows builds #130040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 11, 2025
Merged

gh-130039: Tailcall for windows builds #130040

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ab0a611
Tail-calling flag for Window
Fidget-Spinner Feb 12, 2025
d57c175
Update pythoncore.vcxproj
Fidget-Spinner Feb 12, 2025
3eb568f
Add Windows to the tailcall CI
Fidget-Spinner Feb 12, 2025
4dd19cf
Update tail-call.yml
Fidget-Spinner Feb 12, 2025
7f91920
Update tail-call.yml
Fidget-Spinner Feb 12, 2025
c3d656b
Update pycore_debug_offsets.h
Fidget-Spinner Feb 12, 2025
3638cda
Update pycore_debug_offsets.h
Fidget-Spinner Feb 12, 2025
b8b79ed
Update pycore_debug_offsets.h
Fidget-Spinner Feb 12, 2025
d3766d8
Merge branch 'main' into tailcall_for_windows
Fidget-Spinner Feb 12, 2025
c811b8a
Address review by using env vars
Fidget-Spinner Feb 13, 2025
904b7ee
Merge remote-tracking branch 'upstream/main' into tailcall_for_windows
Fidget-Spinner Feb 13, 2025
991b50f
Merge remote-tracking branch 'upstream/main' into tailcall_for_windows
Fidget-Spinner Feb 15, 2025
166187c
Update pythoncore.vcxproj
Fidget-Spinner Feb 15, 2025
5f7ad24
Update .github/workflows/tail-call.yml
Fidget-Spinner Mar 5, 2025
6d7b689
Update tail-call.yml
Fidget-Spinner Mar 5, 2025
aadfec4
Address review
Fidget-Spinner Mar 5, 2025
1d7c051
Partially revert "Address review"
Fidget-Spinner Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tail-call.yml
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Feb 12, 2025
commit 7f91920bd915123792d1a1ec8e28300f9f27cb16
2 changes: 2 additions & 0 deletions .github/workflows/tail-call.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:

- name: Native Windows (debug)
if: runner.os == 'Windows' && matrix.architecture != 'ARM64'
shell: cmd
run: |
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.5
./PCbuild/build.bat --tail-call-interp -d -p ${{ matrix.architecture }} "/p:PlatformToolset=clangcl" "/p:LLVMToolsVersion=19.1.5" "/p:LLVMInstallDir=C:\Program Files\LLVM"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be convenient to add --clang as a build.bat option, though you'd still need the quoting to get the other variables in.

Also, FWIW, unless you're explicitly trying to override other settings, you can set these variables as environment variables instead. The MSBuild files can override those if it isn't authored properly, but at least PlatformToolset is correct, and I expect the other two will be too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I was thinking of using the default clang that comes with VS. The latest VS comes with Clang 19, so it's perfect for this. However, I don't know if the CI runners updated to use the latest VS yet, and I don't want a situation where sometimes we break on older VS and sometimes we don't. So for now, I'll let users manually specify, and maybe in a year or so we can revisit adding a --clang option.

Expand All @@ -85,6 +86,7 @@ jobs:
# No tests (yet):
- name: Emulated Windows (release)
if: runner.os == 'Windows' && matrix.architecture == 'ARM64'
shell: cmd
run: |
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.5
./PCbuild/build.bat --tail-call-interp -p ${{ matrix.architecture }} "/p:PlatformToolset=clangcl" "/p:LLVMToolsVersion=19.1.5" "/p:LLVMInstallDir=C:\Program Files\LLVM"
Expand Down
Loading
0