8000 gh-126554: correct detection of `gcc` for `TestNullDlsym.test_null_dlsym` by petermarko · Pull Request #129872 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
8000

gh-126554: correct detection of gcc for TestNullDlsym.test_null_dlsym #129872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

gh-126554: correct detection of gcc for TestNullDlsym.test_null_dlsym #129872

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2777a08
ctypes: correct gcc check in test
petermarko Feb 8, 2025
cbec27b
Use OSError
encukou Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ctypes: correct gcc check in test 
In case gcc is not available, it will throw exception and test fails.
So catch the exception to skip the test correctly.

======================================================================
ERROR: test_null_dlsym (test.test_ctypes.test_dlerror.TestNullDlsym.test_null_dlsym)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.12/test/test_ctypes/test_dlerror.py", line 61, in test_null_dlsym
    retcode = subprocess.call(["gcc", "--version"],
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 391, in call
    with Popen(*popenargs, **kwargs) as p:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 1028, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.12/subprocess.py", line 1963, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gcc'

Signed-off-by: Peter Marko <peter.marko@siemens.com>
  • Loading branch information
@petermarko
petermarko committed Feb 9, 2025
commit 2777a08ce4c23d53dc6e09d64a18eb18cfab246d
11 changes: 7 additions & 4 deletions Lib/test/test_ctypes/test_dlerror.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,14 @@ def test_null_dlsym(self):
import subprocess
import tempfile

retcode = subprocess.call(["gcc", "--version"],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL)
if retcode != 0:
try:
retcode = subprocess.call(["gcc", "--version"],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL)
except FileNotFoundError:
self.skipTest("gcc is missing")
if retcode != 0:
self.skipTest("gcc --version failed")

pipe_r, pipe_w = os.pipe()
self.addCleanup(os.close, pipe_r)
Expand Down
Loading
0