GH-121970: Extract implementation_detail into a new extension
#129663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-detail # Conflicts: # Doc/conf.py
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @AA-Turner, I could not cleanly backport this to |
|
Sorry, @AA-Turner, I could not cleanly backport this to |
AA-Turner
added a commit
to AA-Turner/cpython
that referenced
this pull request
Feb 6, 2025
…extension (pythonGH-129663) (cherry picked from commit 4d56c40) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-129739 is a backport of this pull request to the 3.13 branch. |
AA-Turner
added a commit
to AA-Turner/cpython
that referenced
this pull request
Feb 6, 2025
…extension (pythonGH-129663) (cherry picked from commit 4d56c40) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-129740 is a backport of this pull request to the 3.12 branch. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
cmaloney
pushed a commit
to cmaloney/cpython
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested both HTML and gettext output, both identical (given SOURCE_DATE_EPOCH is set).
The
run()function is rewritten for clarity, and we sort the translation strings indummy.html.A
📚 Documentation preview 📚: https://cpython-previews--129663.org.readthedocs.build/