8000 Use roles :data: and :const: for referencing module variables by serhiy-storchaka · Pull Request #129507 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Use roles :data: and :const: for referencing module variables #129507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

Use roles :data: and :const: for referencing module variables #129507

merged 1 commit into from
Feb 4, 2025

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Jan 31, 2025 •
edited by github-actions bot
Loading

This is a continuation of #106892.

📚 Documentation preview 📚: https://cpython-previews--129507.org.readthedocs.build/

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 31, 2025
FFY00
FFY00 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member
@FFY00 FFY00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Serhiy!

Not sure why the CI bot is complaining about the news.

@serhiy-storchaka serhiy-storchaka merged commit 078ab82 into python:main Feb 4, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-module-globals branch February 4, 2025 14:16
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 078ab828b9a21ed0e683941bd141d5017b5f62d9 3.13

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 078ab828b9a21ed0e683941bd141d5017b5f62d9 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 4, 2025
@serhiy-storchaka
[3.13] Use roles :data: and :const: for referencing module variables (p…
8abc1fb 
…ythonGH-129507)

(cherry picked from commit 078ab82)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 4, 2025

GH-129649 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 4, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 4, 2025
@serhiy-storchaka
[3.12] Use roles :data: and :const: for referencing module variables (p…
8c96d16 
…ythonGH-129507)

(cherry picked from commit 078ab82)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Feb 4, 2025

GH-129650 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 4, 2025
serhiy-storchaka added a commit that referenced this pull request Feb 4, 2025
@serhiy-storchaka
[3.13] Use roles :data: and :const: for referencing module variables (G…
4cf3e80 
…H-129507) (GH-129649)

(cherry picked from commit 078ab82)
serhiy-storchaka added a commit that referenced this pull request Feb 4, 2025
@serhiy-storchaka
[3.12] Use roles :data: and :const: for referencing module variables (G…
0d51b29 
…H-129507) (GH-129650)

(cherry picked from commit 078ab82)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@serhiy-storchaka @srinivasreddy
Use roles :data: and :const: for referencing module variables (python…
f5eae46 
…GH-129507)
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@serhiy-storchaka @cmaloney
Use roles :data: and :const: for referencing module variables (python…
c0d1623 
…GH-129507)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@FFY00 FFY00 FFY00 approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @brettcannon @FFY00
0