10000 GH-129386: Add `test.support.reset_code` by brandtbucher · Pull Request #129486 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

GH-129386: Add test.support.reset_code #129486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test.support.reset_code
  • Loading branch information
brandtbucher committed Jan 30, 2025
commit 313708b126a68886a0c904e90062032914f11c73
7 changes: 7 additions & 0 deletions Lib/test/support/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
"BrokenIter",
"in_systemd_nspawn_sync_suppressed",
"run_no_yield_async_fn", "run_yielding_async_fn", "async_yield",
"reset_code",
]


Expand Down Expand Up @@ -1286,6 +1287,12 @@ def requires_specialization_ft(test):
_opcode.ENABLE_SPECIALIZATION_FT, "requires specialization")(test)


def reset_code(f: types.FunctionType) -> types.FunctionType:
"""Clear all specializations, local instrumentation, and JIT code for the given function."""
f.__code__ = f.__code__.replace()
return f


#=======================================================================
# Check for the presence of docstrings.

Expand Down
7 changes: 4 additions & 3 deletions Lib/test/test_capi/test_opt.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
import _opcode

from test.support import (script_helper, requires_specialization,
import_helper, Py_GIL_DISABLED, requires_jit_enabled)
import_helper, Py_GIL_DISABLED, requires_jit_enabled,
reset_code)

_testinternalcapi = import_helper.import_module("_testinternalcapi")

Expand All @@ -19,11 +20,11 @@
@contextlib.contextmanager
def clear_executors(func):
# Clear executors in func before and after running a block
func.__code__ = func.__code__.replace()
reset_code(func)
try:
yield
finally:
func.__code__ = func.__code__.replace()
reset_code(func)


def get_first_executor(func):
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_dis.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import unittest
from test.support import (captured_stdout, requires_debug_ranges,
requires_specialization, cpython_only,
os_helper, import_helper)
os_helper, import_helper, reset_code)
from test.support.bytecode_helper import BytecodeTestCase


Expand Down Expand Up @@ -1356,7 +1356,7 @@ def f():
self.code_quicken(f)
else:
# "copy" the code to un-quicken it:
f.__code__ = f.__code__.replace()
reset_code(f)
for instruction in _unroll_caches_as_Instructions(dis.get_instructions(
f, show_caches=True, adaptive=adaptive
), show_caches=True):
Expand Down
3 changes: 2 additions & 1 deletion Lib/test/test_embed.py
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ def test_specialized_static_code_gets_unspecialized_at_Py_FINALIZE(self):
import importlib._bootstrap
import opcode
import test.test_dis
import test.support

def is_specialized(f):
for instruction in dis.get_instructions(f, adaptive=True):
Expand All @@ -409,7 +410,7 @@ def is_specialized(f):
func = importlib._bootstrap._handle_fromlist

# "copy" the code to un-specialize it:
func.__code__ = func.__code__.replace()
test.support.reset_code(func)

assert not is_specialized(func), "specialized instructions found"

Expand Down
8 changes: 5 additions & 3 deletions Lib/test/test_opcache.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import unittest
from test.support import (threading_helper, check_impl_detail,
requires_specialization, requires_specialization_ft,
cpython_only, requires_jit_disabled)
cpython_only, requires_jit_disabled, reset_code)
from test.support.import_helper import import_module

# Skip this module on other interpreters, it is cpython specific:
Expand Down Expand Up @@ -579,9 +579,9 @@ def assert_races_do_not_crash(
# Reset:
if check_items:
for item in items:
item.__code__ = item.__code__.replace()
reset_code(item)
else:
read.__code__ = read.__code__.replace()
reset_code(read)
# Specialize:
for _ in range(_testinternalcapi.SPECIALIZATION_THRESHOLD):
read(items)
Expand Down Expand Up @@ -1552,6 +1552,7 @@ def test_store_attr_instance_value(self):
class C:
pass

@reset_code
def set_value(n):
c = C()
for i in range(n):
Expand All @@ -1577,6 +1578,7 @@ class C:
for i in range(_testinternalcapi.SHARED_KEYS_MAX_SIZE - 1):
setattr(c, f"_{i}", None)

@reset_code
def set_value(n):
for i in range(n):
c.x = i
Expand Down
0