-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-129205: Update multiprocessing.forkserver to use os.readinto #129425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vstinner
merged 6 commits into
python:main
from
cmaloney:cmaloney/forkserver_read_signed
Jan 30, 2025
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4f452fe
gh-129205: Update multiprocessing.forkserver to use os.readinto
cmaloney d2d5baf
Update 2025-01-28-22-11-41.gh-issue-129205.C-vE8S.rst
cmaloney 9227d4e
Rework loop to only use one read in got it all case
cmaloney 4409ae3
Work in positives
cmaloney 3ef05ba
Rely on memoryview to track length, reduce temporaries
cmaloney 22e6821
Remove news
cmaloney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update 2025-01-28-22-11-41.gh-issue-129205.C-vE8S.rst
- Loading branch information
commit d2d5baf32d801161623fa50290b8bd76956eec78
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
Misc/NEWS.d/next/Library/2025-01-28-22-11-41.gh-issue-129205.C-vE8S.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
:mod:`multiprocessing` forkserver now uses :func:`os.readinto` to read pid | ||
of child processes saving memory allocations and copies.. | ||
of child processes saving memory allocations and copies. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that it's worth it to document this change to end users. I suggest to remove this NEWS entry.