8000 GH-129386: Use symbolic constants for specialization tests by brandtbucher · Pull Request #129415 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

GH-129386: Use symbolic constants for specialization tests #129415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brandtbucher
Copy link
Member
@brandtbucher brandtbucher commented Jan 28, 2025

This changes all of the tests that hardcode assumptions about specialization behavior to use new, exported symbolic constants instead. They were found by changing these thresholds to extremely high/low values and seeing which tests failed.

Copy link
Member
@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@brandtbucher brandtbucher mer 9D2F ged commit 002c4e2 into python:main Jan 29, 2025
52 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.14 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0