8000 GH-129386: Use symbolic constants for specialization tests by brandtbucher · Pull Request #129415 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-129386: Use symbolic constants for specialization tests #129415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

GH-129386: Use symbolic constants for specialization tests #129415

merged 1 commit into from
Jan 29, 2025
+153 −133

Conversation

brandtbucher
Copy link
Member
@brandtbucher brandtbucher commented Jan 28, 2025 •
edited by bedevere-app bot
Loading

This changes all of the tests that hardcode assumptions about specialization behavior to use new, exported symbolic constants instead. They were found by changing these thresholds to extremely high/low values and seeing which tests failed.

@brandtbucher brandtbucher added tests Tests in the Lib/test dir skip news 3.14 bugs and security fixes labels Jan 28, 2025
@brandtbucher brandtbucher self-assigned this Jan 28, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 28, 2025
Open
markshannon
markshannon approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member
@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@brandtbucher brandtbucher merged commit 002c4e2 into python:main Jan 29, 2025
52 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@brandtbucher @srinivasreddy
pythonGH-129386: Use symbolic constants for specialization tests (pyt…
282755b 
…honGH-129415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@markshannon markshannon markshannon approved these changes

Assignees

@brandtbucher brandtbucher

Labels
3.14 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandtbucher @JelleZijlstra @markshannon
0