8000 doc: add social cards generation support in sphinxext-opengraph by FFY00 · Pull Request #129085 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

doc: add social cards generation support in sphinxext-opengraph #129085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify the requirements setup further
Signed-off-by: Filipe Laíns <lains@riseup.net>
  • Loading branch information
FFY00 committed Jan 20, 2025
commit f21ec5ddd893d9926254e3752758fc6d5549737e
8 changes: 3 additions & 5 deletions Doc/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ PAPER =
SOURCES =
DISTVERSION = $(shell $(PYTHON) tools/extensions/patchlevel.py)
IS_PYTHON_BUILD = $(shell $(PYTHON) -c 'import sysconfig; print("true") if sysconfig.is_python_build() else None')
REQUIREMENTS = requirements.txt
REQUIREMENTS_NO_BUILD = requirements-no-build.txt
REQUIREMENTS = $(if $(IS_PYTHON_BUILD),requirements.txt,requirements-no-build.txt)
SPHINXERRORHANDLING = --fail-on-warning

# Internal variables.
Expand Down Expand Up @@ -168,19 +167,18 @@ clean-venv:

.PHONY: venv
venv:
requirements = -r $(REQUIREMENTS) $(if $(IS_PYTHON_BUILD),,-r $(REQUIREMENTS_NO_BUILD))
@if [ -d $(VENVDIR) ] ; then \
echo "venv already exists."; \
echo "To recreate it, remove it first with \`make clean-venv'."; \
else \
echo "Creating venv in $(VENVDIR)"; \
if $(UV) --version >/dev/null 2>&1; then \
$(UV) venv --python=$(PYTHON) $(VENVDIR); \
VIRTUAL_ENV=$(VENVDIR) $(UV) pip install $(requirements); \
VIRTUAL_ENV=$(VENVDIR) $(UV) pip install -r $(REQUIREMENTS); \
else \
$(PYTHON) -m venv $(VENVDIR); \
$(VENVDIR)/bin/python3 -m pip install --upgrade pip; \
$(VENVDIR)/bin/python3 -m pip install $(requirements); \
$(VENVDIR)/bin/python3 -m pip install -r $(REQUIREMENTS); \
fi; \
echo "The venv has been created in the $(VENVDIR) directory"; \
fi
Expand Down
2 changes: 2 additions & 0 deletions Doc/requirements-no-build.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
-r requirements.txt

# Requirements when not running the build Python,
# such as optional native extensions.

Expand Down
Loading
0