8000 Fix definition of a `generator iterator` in `glossary.rst` by dmoisset · Pull Request #128952 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

8000 Fix definition of a generator iterator in glossary.rst #128952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

dmoisset
Copy link
Contributor
@dmoisset dmoisset commented Jan 17, 2025

Fix typo/grammar in glossary.rst

As discussed in https://discuss.python.org/t/typo-in-glossary-entry-for-generator-iterator/77163 , copying here for context:

In the “generator iterator” definition:

Each yield temporarily suspends processing, remembering the location execution state (including local variables and pending try-statements).

I find it hard to parse the first sentence, particularly “the location execution state”. I do know how a generator works, but I’m unsure if this is attempting to say “location and execution state”, “local execution state,” or something else. I am not a native English speaker, but the three nouns on a row are challenging for me to read (if it is a noun phrase, shouldn’t they be dashed?)

Note: The phrase appears again in the “asynchronous generator iterator” entry.

No github issue, based on: Trivial changes, like fixing a typo, do not need an issue.


📚 Documentation preview 📚: https://cpython-previews--128952.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Jan 17, 2025
@picnixz picnixz changed the title Fix typo/grammar in glossary.rst Improve definition of a generator iterator in glossary.rst Jan 17, 2025
@picnixz picnixz changed the title Improve definition of a generator iterator in glossary.rst Fix definition of a generator iterator in glossary.rst Jan 17, 2025
@picnixz picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 17, 2025
@picnixz picnixz requested a review from JelleZijlstra January 17, 2025 18:35
@gpshead gpshead merged commit 8174770 into python:main Jan 18, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @dmoisset for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2025
…128952)

Fix possible typo/grammar in glossary.rst

As discussed in https://discuss.python.org/t/typo-in-glossary-entry-for-generator-iterator/77163
(cherry picked from commit 8174770)

Co-authored-by: Daniel F Moisset <dfmoisset@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Jan 18, 2025

GH-128967 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2025
…128952)

Fix possible typo/grammar in glossary.rst

As discussed in https://discuss.python.org/t/typo-in-glossary-entry-for-generator-iterator/77163
(cherry picked from commit 8174770)

Co-authored-by: Daniel F Moisset <dfmoisset@gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 18, 2025
@bedevere-app
Copy link
bedevere-app bot commented Jan 18, 2025

GH-128968 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 18, 2025
gpshead pushed a commit that referenced this pull request Jan 18, 2025
…-128952) (#128967)

Fix definition of a `generator iterator` in `glossary.rst` (GH-128952)

Fix possible typo/grammar in glossary.rst

As discussed in https://discuss.python.org/t/typo-in-glossary-entry-for-generator-iterator/77163
(cherry picked from commit 8174770)

Co-authored-by: Daniel F Moisset <dfmoisset@gmail.com>
gpshead pushed a commit that referenced this pull request Jan 18, 2025
…-128952) (#128968)

Fix definition of a `generator iterator` in `glossary.rst` (GH-128952)

Fix possible typo/grammar in glossary.rst

As discussed in https://discuss.python.org/t/typo-in-glossary-entry-for-generator-iterator/77163
(cherry picked from commit 8174770)

Co-authored-by: Daniel F Moisset <dfmoisset@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@merwok
Copy link
Member
merwok commented Feb 28, 2025

As noted in the discussion, this was probably a typo for local execution state, which is meaningful. Could you restore the adjective in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants
0