-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-128942: make arraymodule.c free-thread safe #128943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
7c8edcd
gh-128942: make arraymodule.c free-thread safe
tom-pytel b4c38d6
📜🤖 Added by blurb_it.
blurb-it[bot] 523c049
Update 2025-01-17-13-53-32.gh-issue-128942.DxzaIg.rst
tom-pytel 714da01
Update 2025-01-17-13-53-32.gh-issue-128942.DxzaIg.rst
tom-pytel 6893468
refactor array methods to established patterns
tom-pytel 65b4a63
made arrayiter freethread safe
tom-pytel 761d27a
cleanup to match other segfault fix P
8000
R
tom-pytel 0bcd3c7
style nit from other PR
tom-pytel 5676c92
add _Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED()
tom-pytel c18290c
misc style
tom-pytel 6ee2303
misc cleanups
tom-pytel 7d5de1f
misc
tom-pytel 02fc79c
Merge branch 'main' into fix-issue-128942
tom-pytel 0ad9800
3 og 4 requested changes
tom-pytel 325c241
not locking bytes
tom-pytel 7958c55
array_array_frombytes get buffer from clinic
tom-pytel 0532d93
more safe
tom-pytel 6afec34
protect ob_exports exclusively with critical section
tom-pytel f0d5824
Merge branch 'main' into fix-issue-128942
tom-pytel f4058c5
Merge branch 'main' into fix-issue-128942
tom-pytel 1bf45fc
fix clinic stuff that seems to have changed
tom-pytel 6e7b65a
Merge branch 'main' into fix-issue-128942
tom-pytel bb4bf90
iterator safe from multi-crit deadlocks
tom-pytel 4d5bb3a
remove unnecessary crit sect in setstate
tom-pytel e50e653
protect ob_exports atomically
tom-pytel 841a870
2 missed misc atomic writes
tom-pytel a0e36db
Merge branch 'main' into fix-issue-128942
tom-pytel d80c1a5
misc tweaks
tom-pytel 9aa4540
Merge branch 'main' into fix-issue-128942
tom-pytel dffc9cd
add test
tom-pytel b3665fd
misc fix, b'\xdd' -> 0xdd
tom-pytel 3814e53
use support.Py_GIL_DISABLED
tom-pytel cb0345f
Merge branch 'main' into fix-issue-128942
tom-pytel 4a5c568
add critical section held assertions
tom-pytel cc8d715
Py_CLEAR(it->ao)
tom-pytel 5f352a3
make ob_exports non-atomic everywhere
tom-pytel 98f1433
check type before lock in array_ass_subscr()
tom-pytel 2a45a44
Merge branch 'main' into fix-issue-128942
tom-pytel c0799be
Merge branch 'main' into fix-issue-128942
kumaraditya303 0bcde5c
simplify array_arrayiterator___reduce___impl
kumaraditya303 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2025-01-17-13-53-32.gh-issue-128942.DxzaIg.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Make array module safe under :term:`free threading`. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.