10000 gh-109959: Skip test_glob.test_selflink() flaky test by vstinner · Pull Request #128812 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-109959: Skip test_glob.test_selflink() flaky test #128812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

gh-109959: Skip test_glob.test_selflink() flaky test #128812

merged 2 commits into from
Jan 14, 2025

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Jan 14, 2025 •
edited by bedevere-app bot
Loading

@vstinner vstinner added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 14, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 14, 2025
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jan 14, 2025
@vstinner
Copy link
Member Author

cc @colesbury @hugovk

@picnixz picnixz mentioned this pull request Jan 14, 2025
Closed
picnixz
picnixz reviewed Jan 14, 2025
View reviewed changes
@vstinner @picnixz
Update Lib/test/test_glob.py
1fe07f1 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@vstinner vstinner merged commit 1153e66 into python:main Jan 14, 2025
36 checks passed
@vstinner vstinner deleted the skip_glob_selflink branch January 14, 2025 10:18
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2025
@vstinner @miss-islington
pythongh-109959: Skip test_glob.test_selflink() flaky test (pythonGH-…
4e22074 
…128812)

(cherry picked from commit 1153e66)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Jan 14, 2025

GH-128821 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 14, 2025
@vstinner vstinner added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jan 14, 2025
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 1153e66.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/725/builds/9425) and take a look at the build logs.
  4. Check if the failure is related to this commit (1153e66) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/725/builds/9425

Failed tests:

  • test_ssl

Failed subtests:

  • test_preauth_data_to_tls_server - test.test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_server

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py", line 5094, in test_preauth_data_to_tls_server
    self.assertIn("before TLS handshake with data", wrap_error.args[1])
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'before TLS handshake with data' not found in '[SSL: RECORD_LAYER_FAILURE] record layer failure (_ssl.c:1066)'

vstinner added a commit that referenced this pull request Jan 14, 2025
@miss-islington @vstinner
[3.13] gh-109959: Skip test_glob.test_selflink() flaky test (GH-128812)…
88b4b43 
… (#128821)

gh-109959: Skip test_glob.test_selflink() flaky test (GH-128812)
(cherry picked from commit 1153e66)

Co-authored-by: Victor Stinner <vstinner@python.org>
@picnixz
Copy link
Member
picnixz commented Jan 14, 2025

@vstinner 3.12 backport seems to be stuck.

@vstinner vstinner removed the needs backport to 3.12 only security fixes label Jan 14, 2025
@vstinner vstinner added the needs backport to 3.12 only security fixes label Jan 14, 2025
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2025
@vstinner @miss-islington
pythongh-109959: Skip test_glob.test_selflink() flaky test (pythonGH-…
269c3b4 
…128812)

(cherry picked from commit 1153e66)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Jan 14, 2025

GH-128834 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 14, 2025
vstinner added a commit that referenced this pull request Jan 14, 2025
@miss-islington @vstinner
[3.12] gh-109959: Skip test_glob.test_selflink() flaky test (GH-128812)…
febe67b 
… (#128834)

gh-109959: Skip test_glob.test_selflink() flaky test (GH-128812)
(cherry picked from commit 1153e66)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@picnixz picnixz picnixz approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @bedevere-bot @picnixz @hugovk @Eclips4
0