8000 gh-124433: fix docs for `asyncio.Queue.task_done` by kumaraditya303 · Pull Request #128669 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-124433: fix docs for asyncio.Queue.task_done #128669 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

gh-124433: fix docs for asyncio.Queue.task_done #128669

merged 1 commit into from
Jan 9, 2025

Conversation

kumaraditya303
Copy link
Contributor
@kumaraditya303 kumaraditya303 commented Jan 9, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Jan 9, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 9, 2025
Closed
@kumaraditya303 kumaraditya303 linked an issue Jan 9, 2025 that may be closed by this pull request
asyncio.Queue.task_done documentation is ambiguous #124433
Closed
@kumaraditya303 kumaraditya303 merged commit 4322a31 into python:main Jan 9, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 9, 2025
@kumaraditya303 @miss-islington
pythongh-124433: fix docs for asyncio.Queue.task_done (pythonGH-128669
8be399a 
)

(cherry picked from commit 4322a31)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Jan 9, 2025

GH-128671 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 9, 2025
@kumaraditya303 @miss-islington
pythongh-124433: fix docs for asyncio.Queue.task_done (pythonGH-128669
0213e8b 
)

(cherry picked from commit 4322a31)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 9, 2025
@kumaraditya303 kumaraditya303 deleted the docs-async branch January 9, 2025 12:20
@bedevere-app
Copy link
bedevere-app bot commented Jan 9, 2025

GH-128672 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 9, 2025
kumaraditya303 added a commit that referenced this pull request Jan 9, 2025
@miss-islington @kumaraditya303
[3.12] gh-124433: fix docs for asyncio.Queue.task_done (GH-128669) (#…
8bfc68f 
…128672)

gh-124433: fix docs for `asyncio.Queue.task_done` (GH-128669)
(cherry picked from commit 4322a31)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Jan 9, 2025
@miss-islington @kumaraditya303
[3.13] gh-124433: fix docs for asyncio.Queue.task_done (GH-128669) (#…
c57ef49 
…128671)

gh-124433: fix docs for `asyncio.Queue.task_done` (GH-128669)
(cherry picked from commit 4322a31)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graingert graingert graingert approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news topic-asyncio
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asyncio.Queue.task_done documentation is ambiguous
2 participants
@kumaraditya303 @graingert
0