gh-128438: Add EnvironmentVarGuard for test_pdb.py
#128522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnvironmentVarGuard for test_pdb.pyEnvironmentVarGuard for test_pdb.py
EnvironmentVarGuard for test_pdb.pyEnvironmentVarGuard for test_pdb.py
Lib/test/test_pdb.py
Outdated
| if homesave is not None: | ||
| os.environ['HOME'] = homesave | ||
| return stdout, stderr | ||
| return stdout, stderr |
There was a problem hiding this comment.
Leave this return statement out of with and it should be good to go.
gaogaotiantian
approved these changes
Jan 11, 2025
|
@gaogaotiantian can this be backported to ease future backports or do you prefer to leave it like that? (namely, is there any chance that those lines can be changed in future versions?) |
|
I think it's fine to keep it as it is for previous versions. I don't expect frequent changes to these lines and it's definitely not a bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnvironmentVarGuardin tests instead of manually messing withos.environ#128438