-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-128509: A
8000
dd sys._is_immortal
for identifying immortal objects
#128510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
120bc73
Add sys._is_immortal
ZeroIntensity ac45261
Add documentation note.
ZeroIntensity b545f24
Add a note to the docs and fix tests.
ZeroIntensity 49b0ea8
Add some documentation notes.
ZeroIntensity b31efe5
Add a note in the glossary.
ZeroIntensity 45dc9e0
Change up wording.
ZeroIntensity 32d7db0
Add blur
ZeroIntensity 8bb4f62
Merge branch 'main' into is-immortal-sys
ZeroIntensity 638edd0
Remove redundant test case.
ZeroIntensity 20bb910
Merge branch 'main' of https://github.com/python/cpython into is-immo…
ZeroIntensity 64c9a52
Test for sys._is_immortal in the existing case.
ZeroIntensity 7e416e7
Add note about the C API.
ZeroIntensity 10560ef
Revert "Test for sys._is_immortal in the existing case."
ZeroIntensity 51daa10
Align to 80 characters.
ZeroIntensity fdcafec
Move _is_immortal to after _is_interned
ZeroIntensity 380bca7
Switch to the unstable API
ZeroIntensity 74a751a
Fix stray newline change
ZeroIntensity be49c26
Update sysmodule.c
ZeroIntensity 1154cfe
Rerun clinic.
ZeroIntensity a071b86
Merge branch 'main' into is-immortal-sys
kumaraditya303 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Test for sys._is_immortal in the existing case.
- Loading branch information
commit 64c9a5209425a16d7790c428c608924d4634e472
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sys functions must be checked in test_sys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally moved the test from
test_sys
totest_immortal
so we could re-use the test case, but I've reverted it now. Are you ok with the redundancy?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with redundancy. test_capi can be skipped if _testcapi is missing. It's not the case for test_sys. Both tests are useful.