10BC0 gh-128100: Atomic dict load in _PyObject_GenericGetAttrWithDict by wrongnull · Pull Request #128297 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-128100: Atomic dict load in _PyObject_GenericGetAttrWithDict #128297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 30, 2024
Merged

gh-128100: Atomic dict load in _PyObject_GenericGetAttrWithDict #128297

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8ccd02
Implement atomic load and critical section in C code
wrongnull Dec 26, 2024
3d0d584
Add tests
wrongnull Dec 26, 2024
7227e3e
Address the review
wrongnull Dec 27, 2024
b92759a
Remove test case.
colesbury Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove test case. 
It wasn't reporting any TSAN failures before the PR.
  • Loading branch information
@colesbury
colesbury committed Dec 30, 2024
commit b92759a07bf89fa67381d6140a7445f7a44f4d6a
19 changes: 0 additions & 19 deletions Lib/test/test_free_threading/test_races.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,25 +270,6 @@ def mutate():

do_race(set_value, mutate)

def test_generic_getattr(self):
"""Test generic attribute load"""
import concurrent.futures

num_threads = 100


def closure(b, o):
b.wait()
getattr(o, "foo", None)
o.foo = 42

with concurrent.futures.ThreadPoolExecutor(max_workers=num_threads) as executor:
for _ in range(100):
b = threading.Barrier(num_threads)
o = functools.partial(lambda x: x, 42)
for _ in range(num_threads):
executor.submit(functools.partial(closure, b, o))


if __name__ == "__main__":
unittest.main()
Loading
0