8000 gh-111178: fix UBSan failures in `Objects/codeobject.c` by picnixz · Pull Request #128240 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-111178: fix UBSan failures in Objects/codeobject.c #128240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2025
Merged

gh-111178: fix UBSan failures in Objects/codeobject.c #128240

merged 3 commits into from
Jan 13, 2025

Conversation

picnixz
Copy link
Member
@picnixz picnixz commented Dec 25, 2024 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested a review from markshannon as a code owner December 25, 2024 09:18
@bedevere-app bedevere-app bot mentioned this pull request Dec 25, 2024
Closed
markshannon
markshannon reviewed Jan 7, 2025
View reviewed changes
Copy link
Member
@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would benefit from adding a couple of asserts. Otherwise, looks good.

@picnixz
Copy link
Member Author
picnixz commented Jan 7, 2025

Would benefit from adding a couple of asserts. Otherwise, looks good.

Victor modified those files previously and decided on a non-macro formulation (pure pointer cast). I followed the same idea as I didn't want to introduce inconsistencies. Would it make sense to create a macro that performs the assertion on the self itself and replace pointer casts by that macro?

@picnixz picnixz requested a review from markshannon January 11, 2025 10:11
@encukou encukou merged commit 4533036 into python:main Jan 13, 2025
39 checks passed
@picnixz picnixz deleted the fix/ubsan/codeobject-111178 branch January 13, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @markshannon @encukou
0