8000 gh-128184: Fix docstring generation in dataclasses with forward refs by sobolevn · Pull Request #128194 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-128184: Fix docstring generation in dataclasses with forward refs #128194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

gh-128184: Fix docstring generation in dataclasses with forward refs #128194

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d9d994
gh-128184: Fix docstring generation in dataclasses with forward refs
sobolevn Dec 23, 2024
bdfea9f
Also check existing type
sobolevn Dec 25, 2024
d8c6a7f
Merge branch 'main' into issue-128184
sobolevn Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also check existing type
  • Loading branch information
@sobolevn
sobolevn committed Dec 25, 2024
commit bdfea9fc94464c82f133c4de448ba9ab1da28390
4 changes: 2 additions & 2 deletions Lib/test/test_dataclasses/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2354,13 +2354,13 @@ def test_docstring_with_unsolvable_forward_ref_in_init(self):

@dataclass
class C:
def __init__(self, x: X) -> None: ...
def __init__(self, x: X, num: int) -> None: ...
""",
),
ns,
)

self.assertDocStrEqual(ns['C'].__doc__, "C(x:'X')")
self.assertDocStrEqual(ns['C'].__doc__, "C(x:'X',num:'int')")

def test_docstring_with_no_signature(self):
# See https://github.com/python/cpython/issues/103449
Expand Down
Loading
0