gh-127840: pass flags and address from send_fds #127841

mbachry · 2024-12-11T19:08:25Z

The new test is a copy of the existing test using socketpair. Let me know if I should refactor and merge these two somehow.

Issue: socket.send_fds() flags and address parameters have no effect #127840

ghost · 2024-12-11T19:08:28Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2024-12-11T19:08:31Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ZeroIntensity

Happy to see new contributors 😄

Misc/NEWS.d/next/Library/2024-12-11-20-15-00.gh-issue-127840.pt8fiQ.rst

Lib/test/test_socket.py

…t8fiQ.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

ZeroIntensity

LGTM, thanks!

@gpshead, as one of the socket experts, would you mind reviewing?

miss-islington-app · 2025-05-22T02:38:04Z

Thanks @mbachry for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

socket: pass flags and address from send_fds (cherry picked from commit 518c95b) Co-authored-by: Marcin Bachry <hegel666@gmail.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

bedevere-app · 2025-05-22T02:38:15Z

GH-134474 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-05-22T02:38:20Z

GH-134475 is a backport of this pull request to the 3.13 branch.

bedevere-bot · 2025-05-22T02:47:43Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL 3.x (tier-1) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1609/builds/2712) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1609/builds/2712

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_qkt9f__m.sock>
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python__7ampq2z.sock>
k

bedevere-bot · 2025-05-22T02:48:42Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x (tier-3) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/424/builds/10802) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/424/builds/10802

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_pbof1ewy.sock>
k


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_c4s0l6jd.sock>
k

bedevere-bot · 2025-05-22T02:49:55Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x (tier-2) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/725/builds/11042) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/725/builds/11042

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=26, family=1, type=2, proto=0, laddr=./test_python_wz11kla7.sock>
k


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=26, family=1, type=2, proto=0, laddr=./test_python_i_w9uwih.sock>
k

bedevere-bot · 2025-05-22T02:53:56Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Non-Debug with X 3.x (no tier) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1245/builds/5543) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1245/builds/5543

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_ohnp943n.sock>
�[32mok�[0m


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_widcf142.sock>
�[32mok�[0m

bedevere-bot · 2025-05-22T02:54:35Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x (tier-3) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1232/builds/5887) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1232/builds/5887

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python__er5v_tk.sock>
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_ooydm3gw.sock>
k

bedevere-bot · 2025-05-22T03:05:27Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel NoGIL 3.x (tier-1) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1258/builds/5081) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1258/builds/5081

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.nogil/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=9, family=1, type=2, proto=0, laddr=./test_python_q4t3ldap.sock>
k


Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.nogil/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=8, family=1, type=2, proto=0, laddr=./test_python_059fgnzk.sock>
k

gpshead · 2025-05-22T03:08:47Z

hmm, probably need to revert this while figuring those out...

…GH-127841)" This reverts commit 518c95b.

gpshead · 2025-05-22T03:13:06Z

#134482

bedevere-bot · 2025-05-22T03:15:03Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Raspbian 3.x (tier-3) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1678/builds/116) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1678/builds/116

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_xg5dcebk.sock>
k


Traceback (most recent call last):
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_w7b6g3fn.sock>
k

bedevere-bot · 2025-05-22T03:17:59Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x (no tier) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/469/builds/11175) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/469/builds/11175

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_ht3a1kva.sock>
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_s5youw7c.sock>
k

bedevere-bot · 2025-05-22T03:30:18Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/10726) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/10726

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=6, family=1, type=2, proto=0, laddr=./test_python_qamhsx8n.sock>
k


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=5, family=1, type=2, proto=0, laddr=./test_python_r4fctla0.sock>
k

bedevere-bot · 2025-05-22T03:36:48Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.x (tier-1) has failed when building commit 518c95b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/366/builds/9576) and take a look at the build logs.
Check if the failure is related to this commit (518c95b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/366/builds/9576

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=26, family=1, type=2, proto=0, laddr=./test_python_fj5uabmh.sock>
k


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/unittest/case.py", line 615, in _callTestMethod
    result = method()
ResourceWarning: unclosed <socket.socket fd=26, family=1, type=2, proto=0, laddr=./test_python_xtxh8y64.sock>
k

…H-127841)" (#134482) Revert "gh-127840: pass flags and address from send_fds (GH-127841)" This reverts commit 518c95b.

mbachry · 2025-05-22T10:50:02Z

hmm, probably need to revert this while figuring those out...

Right, sorry about that. Forgot to wrap that socket in a context manager in a test case. It's a pity that local make test and CI pass and this trivial error is revealed only after merging. make test TESTPYTHONOPTS=-Werror reproduces the issue locally, but I'm not able to run the entire test suite with warnings on, so it's not a viable permanent solution.

In any case, it's a simple fix, so I can open another pr.

socket: pass flags and address from send_fds

8cf4b59

bedevere-app bot mentioned this pull request Dec 11, 2024

socket.send_fds() flags and address parameters have no effect #127840

Open

bedevere-app bot added the awaiting review label Dec 11, 2024

Add NEWS entry

9cb5009

ZeroIntensity reviewed Dec 12, 2024

View reviewed changes

Misc/NEWS.d/next/Library/2024-12-11-20-15-00.gh-issue-127840.pt8fiQ.rst Outdated Show resolved Hide resolved

Lib/test/test_socket.py Outdated Show resolved Hide resolved

ZeroIntensity added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Dec 12, 2024

mbachry and others added 2 commits December 12, 2024 19:03

Update Misc/NEWS.d/next/Library/2024-12-11-20-15-00.gh-issue-127840.p…

01f92d3

…t8fiQ.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

Simplify test

8f7c058

ZeroIntensity approved these changes Dec 13, 2024

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Dec 13, 2024

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025

gpshead removed the needs backport to 3.12 only security fixes label May 22, 2025

gpshead approved these changes May 22, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels May 22, 2025

gpshead merged commit 518c95b into python:main May 22, 2025
50 checks passed

bedevere-app bot removed the awaiting merge label May 22, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 22, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2025

gpshead added a commit to gpshead/cpython that referenced this pull request May 22, 2025

Revert "pythongh-127840: pass flags and address from send_fds (python…

bca6c17

…GH-127841)" This reverts commit 518c95b.

gpshead added a commit that referenced this pull request May 22, 2025

gh-127840: Revert "gh-127840: pass flags and address from send_fds (G…

296a660

…H-127841)" (#134482) Revert "gh-127840: pass flags and address from send_fds (GH-127841)" This reverts commit 518c95b.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-127840: pass flags and address from send_fds #127841

gh-127840: pass flags and address from send_fds #127841

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gh-127840: pass flags and address from send_fds #127841

gh-127840: pass flags and address from send_fds #127841

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

Uh oh!