gh-126024: fix UBSan failure in unicodeobject.c:find_first_nonascii
#127566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unicodeobject.cunicodeobject.c:find_first_nonascii
colesbury
reviewed
Dec 3, 2024
colesbury
reviewed
Dec 5, 2024
colesbury
approved these changes
Dec 5, 2024
methane
approved these changes
Dec 5, 2024
|
Does this need backports to 3.12 and 3.13? |
Looks like the relevant code is not in 3.13 or earlier, so I guess not. |
Yup, it's only a recent code (that's why I did 2 PRs). |
|
Hum, we have a failure: https://github.com/python/cpython/actions/runs/12200589926/job/34037087571. I'm not sure what happened :( |
|
Ok, let's revert it for now while we investigate. |
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Dec 6, 2024
…irst_nonascii` (pythonGH-127566)" Some hypothesis tests are failing. This reverts commit 36c6178.
|
I'll investigate now. |
|
Hmm... from my limited testing, the failure looks like it also reproduces main before the PR merged. |
|
(I also deduced it; I commented the revert PR). Sorry for the false alarm. But now we have another issue (for which I'll open a new ticket). |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure we can do anything except wrapping the call in a function. Adding an allow list may seem too hard since the line would change everytime we change the code. Or we can just forget about the optimized unaligned load.