8000 GH-126491: Lower heap size limit with faster marking by markshannon · Pull Request #127519 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-126491: Lower heap size limit with faster marking #127519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Dec 6, 2024
Merged

GH-126491: Lower heap size limit with faster marking #127519

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3038a78
Faster marking of reachable objects
markshannon Nov 9, 2024
c024484
Handle more classes in fast marking
markshannon Nov 10, 2024
e8497ae
Add support for asyn generators on fast path. Simplify counting
markshannon Nov 11, 2024
4c1a6bc
Check stackref before converting to PyObject *
markshannon Nov 11, 2024
6efb4c0
Rename stuff
markshannon Nov 13, 2024
b1c7ab0
Remove expand_region_transitively_reachable and use move_all_transiti…
markshannon Nov 13, 2024
07f228b
Merge branch 'main' into faster-marking
markshannon Dec 2, 2024
51ff78e
Fix compiler warnings and linkage
markshannon Dec 2, 2024
df907b5
Fix another linkage issue
markshannon Dec 2, 2024
9ca64f5
Try 'extern'
markshannon Dec 2, 2024
bda13f4
Go back to PyAPI_FUNC and move functions together
markshannon Dec 2, 2024
d9d63c8
Use _Py_FALLTHROUGH
markshannon Dec 2, 2024
57b8820
Add necessary #ifndef Py_GIL_DISABLED
markshannon Dec 2, 2024
a607059
Go back to using tp_traverse, but make traversal more efficient
markshannon Dec 3, 2024
1545508
Tidy up
markshannon Dec 3, 2024
a1a38c8
A bit more tidying up
markshannon Dec 3, 2024
68fc90b
Move all work to do calculations to one place
markshannon Dec 3, 2024
8893cf5
Assume that increments are 50% garbage for work done calculation
markshannon Dec 3, 2024
ba20c7c
Elaborate comment
markshannon Dec 4, 2024
8262bf0
More tweaking of thresholds
markshannon Dec 4, 2024
3c2116e
Do some algebra
markshannon Dec 4, 2024
72d0284
Revert to 2M+I from 3M+I
markshannon Dec 4, 2024
0f182e2
Address review comments
markshannon Dec 5, 2024
d3c21bb
Address review comments and clarify code a bit
markshannon Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Go back to PyAPI_FUNC and move functions together
  • Loading branch information
@markshannon
markshannon committed Dec 2, 2024
commit bda13f44a28ea175ce6d3fea7f5118007f1298e7
2 changes: 1 addition & 1 deletion Include/internal/pycore_frame.h
10000
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ _PyEvalFramePushAndInit(PyThreadState *tstate, _PyStackRef func,
size_t argcount, PyObject *kwnames,
_PyInterpreterFrame *previous);

extern void
PyAPI_FUNC(void)
_PyFrame_MoveUnvisited(_PyInterpreterFrame *frame, PyGC_Head *to, int visited_space);

#ifdef __cplusplus
Expand Down
3 changes: 2 additions & 1 deletion Include/internal/pycore_gc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,8 @@
gcvisitobjects_t callback, void *arg);
#endif

extern void _PyGC_MoveUnvisited(PyObject *op, PyGC_Head *to, int visited_space);
PyAPI_FUNC(void) _PyGC_MoveUnvisited(PyObject *op, PyGC_Head *to, int visited_space);
PyAPI_FUNC(void) _PyFrame_MoveUnvisited(_PyInterpreterFrame *frame, PyGC_Head *to, int visited_space);

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

syntax error: missing ')' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

syntax error: missing '{' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

'PyGC_Head': redefinition; different basic types [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

syntax error: missing ';' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

syntax error: 'type' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

syntax error: ')' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

< 10000 img class="avatar mr-2 flex-shrink-0" src="https://avatars.githubusercontent.com/in/15368?s=20&u=167a342ed94d2a713daf64a8b476ead2cebe1852&v=4" height="20" width="20" alt="" /> GitHub Actions / Windows / build and test (arm64) 

syntax error: missing ')' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

syntax error: missing '{' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

'PyGC_Head': redefinition; different basic types [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (arm64) 

syntax error: missing ';' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

syntax error: missing ')' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

syntax error: missing '{' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

'PyGC_Head': redefinition; different basic types [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

syntax error: missing ';' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

syntax error: 'type' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

syntax error: ')' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

syntax error: missing ')' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

syntax error: missing '{' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

'PyGC_Head': redefinition; different basic types [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (arm64) 

syntax error: missing ';' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

unknown type name ‘_PyInterpreterFrame’; did you mean ‘PyInterpreterState’?

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

syntax error: missing ')' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

syntax error: missing '{' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

'PyGC_Head': redefinition; different basic types [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

syntax error: missing ';' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

syntax error: 'type' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

syntax error: ')' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

syntax error: missing ')' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

syntax error: missing '{' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

'PyGC_Head': redefinition; different basic types [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

syntax error: missing ';' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: missing ')' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: missing '{' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

'PyGC_Head': redefinition; different basic types [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: missing ';' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: 'type' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: ')' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: missing ')' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: missing '{' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

'PyGC_Head': redefinition; different basic types [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 386 in Include/internal/pycore_gc.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

syntax error: missing ';' before '*' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

#ifdef __cplusplus
}
Expand Down
2 changes: 1 addition & 1 deletion Python/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@
_PyTuple_MoveUnvisited(op, reachable, visited_space);
break;
case _Py_TYPE_VERSION_MODULE:
{

Check warning on line 1468 in Python/gc.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

this statement may fall through [-Wimplicit-fallthrough=]

Check warning on line 1468 in Python/gc.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-aarch64) 

this statement may fall through [-Wimplicit-fallthrough=]
PyModuleObject *m = (PyModuleObject *)op;
/* bpo-39824: Don't call m_traverse() if m_size > 0 and md_state=NULL */
if (m->md_def && m->md_def->m_traverse
Expand All @@ -1475,8 +1475,8 @@
}
op = m->md_dict;
assert (op != NULL);
}
/* fall through */
}
case _Py_TYPE_VERSION_DICT:
_PyDict_MoveUnvisited(op, reachable, visited_space);
break;
Expand Down
Loading
0