gh-109798: Normalize _datetime and datetime error messages
#127345
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2423,7 +2423,7 @@ def __new__(cls, offset, name=_Omitted): | |
| if not cls._minoffset <= offset <= cls._maxoffset: | ||
| raise ValueError("offset must be a timedelta " | ||
| "strictly between -timedelta(hours=24) and " | ||
| f"timedelta(hours=24), not {offset!r}") | ||
|
There was a problem hiding this comment. Probably not going to be a great user experience here because of how bad the >>> print(f"{timedelta(hours=-25)!r}")
datetime.timedelta(days=-2, seconds=82800)Maybe it will be clearer if we do it this way: if offset < timedelta(0):
offset_str = f"-{-offset)}"
else:
offset_str = str(offset)That will print stuff like Probably a more elaborate timedelta formatter would be better, since we basically always want this in |
||
| return cls._create(offset, name) | ||
|
|
||
| def __init_subclass__(cls): | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.