8000 gh-59705: Add _thread.set_name() function by vstinner · Pull Request #127338 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-59705: Add _thread.set_name() function #127338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Dec 6, 2024
Merged

gh-59705: Add _thread.set_name() function #127338

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c6d324d
gh-59705: Add _thread.set_name() function
vstinner Nov 27, 2024
63b5d52
Port to macOS
vstinner Nov 27, 2024
9f6a8ab
Add tests
vstinner Nov 27, 2024
d79e7af
Try to fix macOS _get_name()
vstinner Nov 27, 2024
ebd9752
Truncate to 15 bytes; add error handling
vstinner Nov 28, 2024
a7f5651
Address review
vstinner Nov 28, 2024
97ea645
Add test on non-ASCII name truncation
vstinner Nov 28, 2024
78a9ab9
Add test on non-ASCII name
vstinner Nov 28, 2024
dcf13f4
Test long name on non-Linux platforms
vstinner Nov 28, 2024
6ea7e5a
macOS is limited to 63 bytes
vstinner Nov 28, 2024
46721bb
Catch UnicodeEncodeError when seting the name
vstinner Nov 28, 2024
6962116
Add tests
vstinner Nov 28, 2024
5d27da0
Use "replace" error handler
vstinner Nov 28, 2024
b713910
Address review
vstinner Nov 29, 2024
5c20ea1
Use PyInterpreterState filesystem encoding
vstinner Nov 29, 2024
6088b37
FreeBSD truncates to 98 bytes silently
vstinner Dec 2, 2024
3c12d17
Merge branch 'main' into thread_set_name
vstinner Dec 3, 2024
bde935f
Fix test_threading on iOS
vstinner Dec 3, 2024
0584ca3
Fix create_test(): always encode using "replace"
vstinner Dec 3, 2024
7508b6c
Solaris truncates to 31 bytes
vstinner Dec 3, 2024
8000
f4a9f40
Solaris always uses UTF-8
vstinner Dec 4, 2024
ac6d726
Add PYTHREAD_NAME_MAXLEN macro
vstinner Dec 4, 2024
08e5922
Fix configure.ac if PYTHREAD_NAME_MAXLEN is not set
vstinner Dec 4, 2024
681624e
Address Serhiy's review
vstinner Dec 5, 2024
f57339f
Solaris always use UTF-8
vstinner Dec 6, 2024
3941123
Simplify tests
vstinner Dec 6, 2024
2e27043
Use @unittest.skipUnless
vstinner Dec 6, 2024
6ab2944
Solaris uses UTF-8
vstinner Dec 6, 2024
b370c49
Update Lib/test/test_threading.py
vstinner Dec 6, 2024
beeae59
add test on embedded null character
vstinner Dec 6, 2024
ae956a0
Optimize code truncating the name
vstinner Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Port to macOS
  • Loading branch information
@vstinner
vstinner committed Nov 27, 2024
commit 63b5d52518685123cc3d7274f2f9abb26376558c
4 changes: 4 additions & 0 deletions Modules/_threadmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2377,8 +2377,12 @@ static PyObject *
_thread_set_name_impl(PyObject *module, const char *name)
/*[clinic end generated code: output=f051ce549bcd6b8e input=7e29bbdbfb046a04]*/
{
#ifdef __APPLE__
pthread_setname_np(name);
#else
pthread_t thread = pthread_self();
pthread_setname_np(thread, name);
#endif
Py_RETURN_NONE;
}
#endif // HAVE_PTHREAD_SETNAME_NP
Expand Down
Loading
0