E5DC bpo-30152: Reduce the number of imports for argparse. by serhiy-storchaka · Pull Request #1269 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-30152: Reduce the number of imports for argparse. #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 11 commits into from
Sep 25, 2017
Merged

bpo-30152: Reduce the number of imports for argparse. #1269

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eccaf69
bpo-30152: Reduce the number of imports for argparse.
serhiy-storchaka Apr 24, 2017
79b085f
Revert changes in collections.
serhiy-storchaka Apr 26, 2017
30c87cd
Revert movint an argparse import. This will be done in separate PR.
serhiy-storchaka Apr 26, 2017
46c77d3
Revert moving import gettext. gettext is used in ArgumentParser const…
serhiy-storchaka Apr 28, 2017
d8a622c
Add the comments explaining imports inside functions.
serhiy-storchaka Apr 28, 2017
dad5bae
Merge branch 'master' of https://github.com/python/cpython into argpa…
serhiy-storchaka May 4, 2017
578af90
Import copy only when items is not a list.
serhiy-storchaka May 4, 2017
48a2abf
Fix a bug in _copy_items().
serhiy-storchaka May 4, 2017
502bf6a
Merge branch 'master' into argparse-reduce-import
serhiy-storchaka Sep 23, 2017
c449538
Merge branch 'master' of https://github.com/python/cpython into argpa…
serhiy-storchaka Sep 24, 2017
025688d
Get rid of importing errno.
serhiy-storchaka Sep 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a bug in _copy_items().
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed May 4, 2017
commit 48a2abf5b37dea3966131cd9a1bab35a7062842a
2 changes: 1 addition & 1 deletion Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def _copy_items(items):
if type(items) is list:
Copy link
Member
@vstinner vstinner Sep 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not isinstance(items, list)?

Copy link
Member Author
@serhiy-storchaka serhiy-storchaka Sep 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list subclass can override __copy__ or __reduce__.

return items[:]
Copy link
Member
@vstinner vstinner Sep 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not items.copy()?

Copy link
Member Author
@serhiy-storchaka serhiy-storchaka Sep 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is shorter.

Copy link
Contributor
@rhettinger rhettinger Sep 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it's faster.

import copy
items = copy.copy(items)
return copy.copy(items)


# ===============
Expand Down
0