8000 gh-109413: Enable `strict_optional = true` for `libregrtest/run_workers` by sobolevn · Pull Request #126855 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-109413: Enable strict_optional = true for libregrtest/run_workers #126855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 18, 2024
Merged

gh-109413: Enable strict_optional = true for libregrtest/run_workers #126855

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7c5f178
gh-109413: Enable `strict_optional = true` for `libregrtest/run_workers`
sobolevn Nov 15, 2024
21fd256
Address review
sobolevn Nov 15, 2024
304065d
Address review
sobolevn Nov 15, 2024
9475401
Fix CI
sobolevn Nov 15, 2024
a4e1071
Apply suggestions from code review
sobolevn Nov 15, 2024
ed9a8e3
Address review
sobolevn Nov 15, 2024
b2d6a89
Address review
sobolevn Nov 18, 2024
676e426
Address review
sobolevn Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
@sobolevn @AlexWaygood
sobolevn and AlexWaygood authored Nov 15, 2024
commit a4e10713bbb73f50b97e9c4725abba59a1d9ce6c
4 changes: 2 additions & 2 deletions Lib/test/libregrtest/run_workers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def __init__(self, worker_id: int, runner: "RunWorkers") -> None:
def current_test_name(self) -> TestName:
if self.test_name is None:
raise ValueError(
'Should never call `.test_name` before calling `.run()`'
'Should never call `.current_test_name()` before calling `.run()`'
)
return self.test_name

Expand Down Expand Up @@ -426,7 +426,7 @@ def _wait_completed(self) -> None:
popen = self._popen
# only needed for mypy:
if popen is None:
raise ValueError("Should never call `._popen` before `.run()`")
raise ValueError("Should never access `._popen` before calling `.run()`")

try:
popen.wait(WAIT_COMPLETED_TIMEOUT)
Expand Down
Loading
0